-
Notifications
You must be signed in to change notification settings - Fork 463
Fix training data for gritlm #1932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -13,12 +13,7 @@ | |||
|
|||
GRIT_LM_TRAINING_DATA = { | |||
**E5_TRAINING_DATA, # source https://arxiv.org/pdf/2402.09906 | |||
# also uses medi2 which contains fever and hotpotqa: | |||
"FEVER": ["train"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doesn't it appear in Table 29?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry fixed it - There was a bug with E5_TRAINING_DATA being used for e5-mistral thus I reused that one here but should have been E5_MISTRAL_..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a great!
Good to merge this one? |
@@ -13,12 +13,7 @@ | |||
|
|||
GRIT_LM_TRAINING_DATA = { | |||
**E5_TRAINING_DATA, # source https://arxiv.org/pdf/2402.09906 | |||
# also uses medi2 which contains fever and hotpotqa: | |||
"FEVER": ["train"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a great!
No description provided.