Skip to content

Switch from elyra-code-viewer to jupyterlab-code-viewer #3265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2025
Merged

Switch from elyra-code-viewer to jupyterlab-code-viewer #3265

merged 1 commit into from
Mar 17, 2025

Conversation

lresende
Copy link
Member

@lresende lresende commented Dec 31, 2024 •
edited
Loading

What changes were proposed in this pull request?

Switch from elyra-code-viewer to jupyterlab-code-viewer

Fixes #2711

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@lresende lresende added this to the 4.0.0 milestone Dec 31, 2024
@lresende lresende force-pushed the lresende-code-viewer branch from d575d60 to 0540d26 Compare January 1, 2025 02:48
@lresende lresende requested a review from caponetto January 2, 2025 18:29
@caponetto
Copy link
Contributor

@lresende are we handling the additional stuff from #2711 in a separate PR, such as updating docs and deprecating/removing the code-viewer-extension package?

@lresende
Copy link
Member Author

lresende commented Jan 2, 2025

I want someone other than me to confirm it has been switched properly, and I can handle the other clean-up items with additional commits.

@caponetto
Copy link
Contributor

NP! I can build and test it locally too.
As I'm unfamiliar with all the use cases for the Code Viewer extension, could you please provide the steps for this test?

@shalberd
Copy link
Contributor

shalberd commented Jan 6, 2025 •
edited
Loading

We should also

Edit:

I want someone other than me to confirm it has been switched properly, and I can handle the other clean-up items with additional commits

Ah, I see, good idea.

@lresende
Switch from elyra-code-viewer to jupyterlab-code-viewer
056ffbf 
Signed-off-by: Luciano Resende <lresende@apple.com>
@lresende lresende force-pushed the lresende-code-viewer branch from 0540d26 to 056ffbf Compare March 16, 2025 05:10
@codecov Codecov
Copy link

codecov bot commented Mar 16, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@73d27a8). Learn more about missing BASE report.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3265   +/-   ##
=======================================
  Coverage        ?   83.80%           
=======================================
  Files           ?      158           
  Lines           ?    19939           
  Branches        ?      503           
=======================================
  Hits            ?    16709           
  Misses          ?     3048           
  Partials        ?      182

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lresende lresende requested a review from shalberd March 17, 2025 15:35
caponetto
caponetto approved these changes Mar 17, 2025
View reviewed changes
Copy link
Contributor

@caponetto caponetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shalberd
Copy link
Contributor

@lresende nice work, looks good to me, too. Neat to see this kind of functionality "ability to display a given chunk of code (string) in a transient read-only ‘editor’ without needing to create a file" in Jupyterlab now.

@lresende lresende merged commit a05e5a5 into elyra-ai:main Mar 17, 2025
20 checks passed
@lresende lresende deleted the lresende-code-viewer branch March 17, 2025 19:18
caponetto pushed a commit to caponetto/opendatahub-io-elyra that referenced this pull request Jul 29, 2025
@lresende @caponetto
Switch from elyra-code-viewer to jupyterlab-code-viewer (elyra-ai#3265)
46bcda3 
Signed-off-by: Luciano Resende <lresende@apple.com>
caponetto added a commit to opendatahub-io/elyra that referenced this pull request Aug 4, 2025
@caponetto @lresende @dependabot
Cherry-pick improvements from upstream to main (#125)
b15353d 
* Update jupyterlab-git to 0.51.2 to fix vulnerability (elyra-ai#3319)

Signed-off-by: Luciano Resende <lresende@apple.com>

* Switch from elyra-code-viewer to jupyterlab-code-viewer (elyra-ai#3265)

Signed-off-by: Luciano Resende <lresende@apple.com>

* Update changelog for release 4.0.0rc2

Signed-off-by: Luciano Resende <lresende@apple.com>

* Bump braces from 3.0.2 to 3.0.3 (elyra-ai#3309)

Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3.
- [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md)
- [Commits](micromatch/braces@3.0.2...3.0.3)

---
updated-dependencies:
- dependency-name: braces
  dependency-version: 3.0.3
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump tornado from 6.4.2 to 6.5.1 in /etc/generic (elyra-ai#3313)

Bumps [tornado](https://github.com/tornadoweb/tornado) from 6.4.2 to 6.5.1.
- [Changelog](https://github.com/tornadoweb/tornado/blob/master/docs/releases.rst)
- [Commits](tornadoweb/tornado@v6.4.2...v6.5.1)

---
updated-dependencies:
- dependency-name: tornado
  dependency-version: 6.5.1
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump requests from 2.32.3 to 2.32.4 in /etc/generic (elyra-ai#3314)

Bumps [requests](https://github.com/psf/requests) from 2.32.3 to 2.32.4.
- [Release notes](https://github.com/psf/requests/releases)
- [Changelog](https://github.com/psf/requests/blob/main/HISTORY.md)
- [Commits](psf/requests@v2.32.3...v2.32.4)

---
updated-dependencies:
- dependency-name: requests
  dependency-version: 2.32.4
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump form-data from 4.0.0 to 4.0.4 (elyra-ai#3317)

---
updated-dependencies:
- dependency-name: form-data
  dependency-version: 4.0.4
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update changelog for release 4.0.0rc4 (elyra-ai#3318)

Signed-off-by: Luciano Resende <lresende@apple.com>

* Update changelog for release 4.0.0rc5

Signed-off-by: Luciano Resende <lresende@apple.com>

---------

Signed-off-by: Luciano Resende <lresende@apple.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Luciano Resende <lresende@apple.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caponetto caponetto caponetto approved these changes

@shalberd shalberd Awaiting requested review from shalberd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

Switch to using the Code Viewer in core Jupyterlab
3 participants
@lresende @caponetto @shalberd