-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
fix(linux): productName
should be used as the default value when executableName
is not set per docs (#9068)
#9068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…utableName is not set. (electron-userland#8766)
🦋 Changeset detectedLatest commit: 72b2996 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
I saw that
|
I changed
|
This looks correct but I'll need to double check the full logic flow when I can find a chance. (Currently working on some other high-pri issues) |
@hbcraft is this resolving a specific github issue? Just wondering if there's an issue we can link this PR to for closing it |
As the id #8766 in the title
|
productName
should be used as the default value when executableName
is not set per docs (#9068)
FYI Because I am uploading to snap, this broke my build. My I fixed the problem by setting |
Hmmm thanks for calling that out. I am hesitant to consider this a breaking change as it's technically fixing a bug -> prod behavior is different than what the jsdoc's states the behavior should be. Just curious, what did you set the |
Here is the change I made. My Indeed, I figured it would be difficult to consider this a breaking change. Reminds me of this XKCD comic: |
* Executable name change "electron-mail => ElectronMail" in v5.3.1 got caused by electron-userland/electron-builder#9068.
* Unintentional "electron-mail => ElectronMail" renaming in v5.3.1 got caused by electron-userland/electron-builder#9068.
* Unintentional "electron-mail => ElectronMail" renaming in v5.3.1 got caused by electron-userland/electron-builder#9068.
* Unintentional "electron-mail => ElectronMail" renaming in v5.3.1 got caused by electron-userland/electron-builder#9068.
* Unintentional "electron-mail => ElectronMail" renaming in v5.3.1 got caused by electron-userland/electron-builder#9068.
* Unintentional "electron-mail => ElectronMail" renaming in v5.3.1 got caused by electron-userland/electron-builder#9068.
* Unintentional "electron-mail => ElectronMail" renaming in v5.3.1 got caused by electron-userland/electron-builder#9068.
* Unintentional "electron-mail => ElectronMail" renaming in v5.3.1 got caused by electron-userland/electron-builder#9068.
* Unintentional "electron-mail => ElectronMail" renaming in v5.3.1 got caused by electron-userland/electron-builder#9068.
* Unintentional "electron-mail => ElectronMail" renaming in v5.3.1 got caused by electron-userland/electron-builder#9068.
* Unintentional "electron-mail => ElectronMail" renaming in v5.3.1 got caused by electron-userland/electron-builder#9068.
* Unintentional "electron-mail => ElectronMail" renaming in v5.3.1 got caused by electron-userland/electron-builder#9068.
* Unintentional "electron-mail => ElectronMail" renaming in v5.3.1 got caused by electron-userland/electron-builder#9068.
* Unintentional "electron-mail => ElectronMail" renaming in v5.3.1 got caused by electron-userland/electron-builder#9068.
* Unintentional "electron-mail => ElectronMail" renaming in v5.3.1 got caused by electron-userland/electron-builder#9068.
* Unintentional "electron-mail => ElectronMail" renaming in v5.3.1 got caused by electron-userland/electron-builder#9068.
* Unintentional "electron-mail => ElectronMail" renaming in v5.3.1 got caused by electron-userland/electron-builder#9068.
* Unintentional "electron-mail => ElectronMail" renaming in v5.3.1 got caused by electron-userland/electron-builder#9068.
* Unintentional "electron-mail => ElectronMail" renaming in v5.3.1 got caused by electron-userland/electron-builder#9068.
* Unintentional "electron-mail => ElectronMail" renaming in v5.3.1 got caused by electron-userland/electron-builder#9068.
* Unintentional "electron-mail => ElectronMail" renaming in v5.3.1 got caused by electron-userland/electron-builder#9068.
I have conducted tests in my project and it seems there are no issues.
Fixes: #8766