Skip to content

Conversation

hbcraft
Copy link
Contributor

@hbcraft hbcraft commented Apr 29, 2025

I have conducted tests in my project and it seems there are no issues.

Fixes: #8766

The above content is translated by a translation tool. Please ignore any errors in it.

Copy link

changeset-bot bot commented Apr 29, 2025

🦋 Changeset detected

Latest commit: 72b2996

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-builder Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@hbcraft
Copy link
Contributor Author

hbcraft commented Apr 29, 2025

I saw that Test App ßW.xml was generated during the test instead of testapp.xml. Should I change testapp.xml in the test file to Test App ßW.xml? Or is there any other way for me to fix this error?

The above content was translated by a translation tool. Please ignore any errors in it.

@hbcraft
Copy link
Contributor Author

hbcraft commented Apr 30, 2025

I changed testapp.xml in test/src/linux/debTest.ts:107 to Test App ßW.xml, and the tests running on my computer passed, but I don't know if this change is reasonable.

The above content was translated by a translation tool. Please ignore any errors in it.

@mmaietta
Copy link
Collaborator

This looks correct but I'll need to double check the full logic flow when I can find a chance. (Currently working on some other high-pri issues)

@mmaietta
Copy link
Collaborator

@hbcraft is this resolving a specific github issue? Just wondering if there's an issue we can link this PR to for closing it

@hbcraft
Copy link
Contributor Author

hbcraft commented May 21, 2025

As the id #8766 in the title

The above content was translated by a translation tool. Please ignore any errors in it.

@mmaietta mmaietta merged commit 59fdaa9 into electron-userland:master May 21, 2025
19 checks passed
@mmaietta mmaietta changed the title fix(linux): productName should be used as the default value when executableName is not set. (#8766) fix(linux): productName should be used as the default value when executableName is not set per docs (#9068) May 21, 2025
@github-actions github-actions bot mentioned this pull request May 20, 2025
@tjcouch-sil
Copy link

FYI Because I am uploading to snap, this broke my build. My name has only alphanumeric and dashes, but my productName has a period. I imagine you probably don't want to retroactively consider this a breaking change; just noting.

I fixed the problem by setting executableName in the linux property in my electron-builder config.

@mmaietta
Copy link
Collaborator

mmaietta commented Jun 6, 2025

Hmmm thanks for calling that out. I am hesitant to consider this a breaking change as it's technically fixing a bug -> prod behavior is different than what the jsdoc's states the behavior should be.

Just curious, what did you set the executableName to?

@tjcouch-sil
Copy link

Here is the change I made. My package.json has "name": "platform-bible", but my electron-builder config has productName: 'Platform.Bible', so I needed to add executableName: 'platform-bible' in the linux property in the electron-builder config.

Indeed, I figured it would be difficult to consider this a breaking change. Reminds me of this XKCD comic:

XKCD comic demonstrating that breaking changes murder children

vladimiry added a commit to vladimiry/ElectronMail that referenced this pull request Jul 29, 2025
* Executable name change "electron-mail => ElectronMail" in v5.3.1 got caused by electron-userland/electron-builder#9068.
vladimiry added a commit to vladimiry/ElectronMail that referenced this pull request Jul 30, 2025
* Unintentional "electron-mail => ElectronMail" renaming in v5.3.1 got caused by electron-userland/electron-builder#9068.
vladimiry added a commit to vladimiry/ElectronMail that referenced this pull request Jul 30, 2025
* Unintentional "electron-mail => ElectronMail" renaming in v5.3.1 got caused by electron-userland/electron-builder#9068.
vladimiry added a commit to vladimiry/ElectronMail that referenced this pull request Jul 30, 2025
* Unintentional "electron-mail => ElectronMail" renaming in v5.3.1 got caused by electron-userland/electron-builder#9068.
vladimiry added a commit to vladimiry/ElectronMail that referenced this pull request Jul 30, 2025
* Unintentional "electron-mail => ElectronMail" renaming in v5.3.1 got caused by electron-userland/electron-builder#9068.
vladimiry added a commit to vladimiry/ElectronMail that referenced this pull request Jul 30, 2025
* Unintentional "electron-mail => ElectronMail" renaming in v5.3.1 got caused by electron-userland/electron-builder#9068.
vladimiry added a commit to vladimiry/ElectronMail that referenced this pull request Jul 30, 2025
* Unintentional "electron-mail => ElectronMail" renaming in v5.3.1 got caused by electron-userland/electron-builder#9068.
vladimiry added a commit to vladimiry/ElectronMail that referenced this pull request Jul 30, 2025
* Unintentional "electron-mail => ElectronMail" renaming in v5.3.1 got caused by electron-userland/electron-builder#9068.
vladimiry added a commit to vladimiry/ElectronMail that referenced this pull request Jul 30, 2025
* Unintentional "electron-mail => ElectronMail" renaming in v5.3.1 got caused by electron-userland/electron-builder#9068.
vladimiry added a commit to vladimiry/ElectronMail that referenced this pull request Jul 30, 2025
* Unintentional "electron-mail => ElectronMail" renaming in v5.3.1 got caused by electron-userland/electron-builder#9068.
vladimiry added a commit to vladimiry/ElectronMail that referenced this pull request Jul 30, 2025
* Unintentional "electron-mail => ElectronMail" renaming in v5.3.1 got caused by electron-userland/electron-builder#9068.
vladimiry added a commit to vladimiry/ElectronMail that referenced this pull request Jul 30, 2025
* Unintentional "electron-mail => ElectronMail" renaming in v5.3.1 got caused by electron-userland/electron-builder#9068.
vladimiry added a commit to vladimiry/ElectronMail that referenced this pull request Jul 30, 2025
* Unintentional "electron-mail => ElectronMail" renaming in v5.3.1 got caused by electron-userland/electron-builder#9068.
vladimiry added a commit to vladimiry/ElectronMail that referenced this pull request Jul 30, 2025
* Unintentional "electron-mail => ElectronMail" renaming in v5.3.1 got caused by electron-userland/electron-builder#9068.
vladimiry added a commit to vladimiry/ElectronMail that referenced this pull request Jul 31, 2025
* Unintentional "electron-mail => ElectronMail" renaming in v5.3.1 got caused by electron-userland/electron-builder#9068.
vladimiry added a commit to vladimiry/ElectronMail that referenced this pull request Aug 1, 2025
* Unintentional "electron-mail => ElectronMail" renaming in v5.3.1 got caused by electron-userland/electron-builder#9068.
vladimiry added a commit to vladimiry/ElectronMail that referenced this pull request Aug 1, 2025
* Unintentional "electron-mail => ElectronMail" renaming in v5.3.1 got caused by electron-userland/electron-builder#9068.
vladimiry added a commit to vladimiry/ElectronMail that referenced this pull request Aug 1, 2025
* Unintentional "electron-mail => ElectronMail" renaming in v5.3.1 got caused by electron-userland/electron-builder#9068.
vladimiry added a commit to vladimiry/ElectronMail that referenced this pull request Aug 1, 2025
* Unintentional "electron-mail => ElectronMail" renaming in v5.3.1 got caused by electron-userland/electron-builder#9068.
vladimiry added a commit to vladimiry/ElectronMail that referenced this pull request Aug 2, 2025
* Unintentional "electron-mail => ElectronMail" renaming in v5.3.1 got caused by electron-userland/electron-builder#9068.
vladimiry added a commit to vladimiry/ElectronMail that referenced this pull request Aug 2, 2025
* Unintentional "electron-mail => ElectronMail" renaming in v5.3.1 got caused by electron-userland/electron-builder#9068.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When executableName is not set under Linux, productName is not used as the default value.
3 participants