-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Import brightray source and remove submodule #9423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flags to control iwa enabled server whitelist
Conflicts: browser/url_request_context_getter.cc browser/url_request_context_getter.h
Update to Chrome 51
initialize bluetooth for linux
Fix double free when closing window with devtools opened
Redispatch key events to handle native shortcuts
Replace --whole-archive with --start-group
Otherwise Electron would crash on exit in Chrome 58.
Upgrade to Chrome 58
Upgrade to 58.0.3029.96
Upgrade to 58.0.3029.96
Upgrade to Chrome 58.0.3029.110
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull imports the source code from https://github.com/electron/brightray into this repository.
Brightray started as a submodule/separate codebase because it was planned to be used by other projects but this never really panned out and so having it separated has no benefit to Electron, makes contributions more difficult, and makes Chrome upgrades more complicated.
This pull request includes the original history so blame/log/etc. should work still.
You can browse the imported history from https://github.com/electron/electron/tree/brightray-import/brightray
/cc @electron/maintainers
After Merging