Skip to content

Conversation

dmlemeshko
Copy link
Member

@dmlemeshko dmlemeshko commented May 15, 2025

Summary

Part of https://github.com/elastic/kibana-team/issues/1503

This PR is mostly about moving tests from x-pack/test to x-pack/platform/test

Before:

x-pack/test/
     | - encrypted_saved_objects_api_integration/
     | - plugin_api_integration/

After:

x-pack/platform/test/
     | - encrypted_saved_objects_api_integration/
     | - plugin_api_integration/

@dmlemeshko dmlemeshko requested a review from marius-dr May 16, 2025 01:01
@dmlemeshko dmlemeshko added v9.1.0 v8.19.0 backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes labels May 18, 2025
@dmlemeshko dmlemeshko marked this pull request as ready for review May 18, 2025 15:43
@dmlemeshko dmlemeshko requested review from a team as code owners May 18, 2025 15:43
@@ -5,7 +5,7 @@
* 2.0.
*/

import { services as commonServices } from '../common/services';
import { commonFunctionalServices as commonServices } from '@kbn/ftr-common-functional-services';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default FTR services are good enough for these tests

Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

response ops changes LGTM

Copy link
Contributor

@kc13greiner kc13greiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dmlemeshko dmlemeshko requested a review from Copilot June 3, 2025 08:46
zacharyparikh pushed a commit to zacharyparikh/kibana that referenced this pull request Jun 4, 2025
## Summary

Part of elastic/kibana-team#1503

This PR is mostly about moving tests from x-pack/test to
x-pack/platform/test

Before:

```
x-pack/test/
     | - encrypted_saved_objects_api_integration/
     | - plugin_api_integration/
```

After: 
```
x-pack/platform/test/
     | - encrypted_saved_objects_api_integration/
     | - plugin_api_integration/
```

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 5, 2025
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 220803 locally
cc: @dmlemeshko

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 220803 locally
cc: @dmlemeshko

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 220803 locally
cc: @dmlemeshko

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 220803 locally
cc: @dmlemeshko

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 220803 locally
cc: @dmlemeshko

1 similar comment
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 220803 locally
cc: @dmlemeshko

nickpeihl pushed a commit to nickpeihl/kibana that referenced this pull request Jun 12, 2025
## Summary

Part of elastic/kibana-team#1503

This PR is mostly about moving tests from x-pack/test to
x-pack/platform/test

Before:

```
x-pack/test/
     | - encrypted_saved_objects_api_integration/
     | - plugin_api_integration/
```

After: 
```
x-pack/platform/test/
     | - encrypted_saved_objects_api_integration/
     | - plugin_api_integration/
```

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 220803 locally
cc: @dmlemeshko

1 similar comment
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 220803 locally
cc: @dmlemeshko

dmlemeshko added a commit to dmlemeshko/kibana that referenced this pull request Jun 17, 2025
## Summary

Part of elastic/kibana-team#1503

This PR is mostly about moving tests from x-pack/test to
x-pack/platform/test

Before:

```
x-pack/test/
     | - encrypted_saved_objects_api_integration/
     | - plugin_api_integration/
```

After:
```
x-pack/platform/test/
     | - encrypted_saved_objects_api_integration/
     | - plugin_api_integration/
```

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit f93e3b0)

# Conflicts:
#	.github/CODEOWNERS
#	x-pack/platform/test/tsconfig.json
@dmlemeshko
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @dmlemeshko

dmlemeshko added a commit that referenced this pull request Jun 18, 2025
# Backport

This will backport the following commits from `main` to `8.19`:
- [[ska][x-pack] relocate platform tests [7]
(#220803)](#220803)

<!--- Backport version: 10.0.0 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Dzmitry
Lemechko","email":"dzmitry.lemechko@elastic.co"},"sourceCommit":{"committedDate":"2025-06-03T12:57:31Z","message":"[ska][x-pack]
relocate platform tests [7] (#220803)\n\n## Summary\n\nPart of
https://github.com/elastic/kibana-team/issues/1503\n\nThis PR is mostly
about moving tests from x-pack/test
to\nx-pack/platform/test\n\nBefore:\n\n```\nx-pack/test/\n | -
encrypted_saved_objects_api_integration/\n | -
plugin_api_integration/\n```\n\nAfter: \n```\nx-pack/platform/test/\n |
- encrypted_saved_objects_api_integration/\n | -
plugin_api_integration/\n```\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"f93e3b0178859bde8e3a8d0b3e23e47b744adc56","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport
missing","backport:version","v9.1.0","v8.19.0"],"title":"[ska][x-pack]
relocate platform tests
[7]","number":220803,"url":"https://github.com/elastic/kibana/pull/220803","mergeCommit":{"message":"[ska][x-pack]
relocate platform tests [7] (#220803)\n\n## Summary\n\nPart of
https://github.com/elastic/kibana-team/issues/1503\n\nThis PR is mostly
about moving tests from x-pack/test
to\nx-pack/platform/test\n\nBefore:\n\n```\nx-pack/test/\n | -
encrypted_saved_objects_api_integration/\n | -
plugin_api_integration/\n```\n\nAfter: \n```\nx-pack/platform/test/\n |
- encrypted_saved_objects_api_integration/\n | -
plugin_api_integration/\n```\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"f93e3b0178859bde8e3a8d0b3e23e47b744adc56"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/220803","number":220803,"mergeCommit":{"message":"[ska][x-pack]
relocate platform tests [7] (#220803)\n\n## Summary\n\nPart of
https://github.com/elastic/kibana-team/issues/1503\n\nThis PR is mostly
about moving tests from x-pack/test
to\nx-pack/platform/test\n\nBefore:\n\n```\nx-pack/test/\n | -
encrypted_saved_objects_api_integration/\n | -
plugin_api_integration/\n```\n\nAfter: \n```\nx-pack/platform/test/\n |
- encrypted_saved_objects_api_integration/\n | -
plugin_api_integration/\n```\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"f93e3b0178859bde8e3a8d0b3e23e47b744adc56"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes v8.19.0 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants