Skip to content

Conversation

gpetrou
Copy link
Contributor

@gpetrou gpetrou commented Jun 22, 2025

@flobernd
Copy link
Member

Hi @gpetrou , thanks for the PR.

I'm usually running a "report everything & treat warnings as errors" .editorconfig for the analyzer rules. The Elasticsearch client repo is not quite ready for this (yet), but that's definitely the goal.

@gpetrou
Copy link
Contributor Author

gpetrou commented Jul 2, 2025

@flobernd do I need to do any changes or could we merge this one?

@flobernd flobernd merged commit 1f98816 into elastic:main Jul 2, 2025
26 of 28 checks passed
@flobernd
Copy link
Member

flobernd commented Jul 2, 2025

Hi @gpetrou , I merged it right now. Thanks again! FYI: I'm on leave until August; there won't be a lot of movement here in the meantime.

github-actions bot pushed a commit that referenced this pull request Jul 2, 2025
(cherry picked from commit 1f98816)
github-actions bot pushed a commit that referenced this pull request Jul 2, 2025
(cherry picked from commit 1f98816)
Copy link
Contributor

github-actions bot commented Jul 2, 2025

💚 All backports created successfully

Status Branch Result
8.19
9.0

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

github-actions bot pushed a commit that referenced this pull request Aug 4, 2025
(cherry picked from commit 1f98816)
Copy link
Contributor

github-actions bot commented Aug 4, 2025

💚 All backports created successfully

Status Branch Result
9.1

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

flobernd pushed a commit that referenced this pull request Aug 4, 2025
Co-authored-by: gpetrou <4172445+gpetrou@users.noreply.github.com>
flobernd pushed a commit that referenced this pull request Aug 4, 2025
Co-authored-by: gpetrou <4172445+gpetrou@users.noreply.github.com>
flobernd pushed a commit that referenced this pull request Aug 4, 2025
Co-authored-by: gpetrou <4172445+gpetrou@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants