Making rendering useful for formatting files (2) #454
Conversation
|
Ping @kastoestoramadus - what do you think? |
|
Sure, not sure if I fix all of them but will solve some of them. |
|
I made some changes to your code - they look ok? I was just pointing out that we are going a new direction and there could be some bumps in the road. Maybe the lightbend library will accept your changes but who knows. Let me know how it goes with your tool after I make a release. |
| @@ -37,7 +36,7 @@ object ConfigRenderOptions { | |||
| case class FormattingOptions( | |||
| keepOriginOrder: Boolean = false, | |||
| doubleIndent: Boolean = true, | |||
| doubleColonAssign: Boolean = false, | |||
| colonAssign: Boolean = false, | |||
There was a problem hiding this comment.
plus you've covered defaults with tests. Your changes look good
|
Polish Scala community said not to count on Lightbend with their library. |
|
With my current employer I got some spare time at work. I'll look from time to time to this repo to help a bit. |
|
Thanks for the review. They finally recently took new changes. |
|
Can be tested using |
|
@kastoestoramadus Sorry to bug you but I think I would have to add this feature before I can release to maintain source compatibility with lightbend/config with this PR as seen here - lightbend/config#798 They added a boolean before your latest rendering edition. I do have a Discord for |
|
@ekrich ok, will do it. Starting the work on it. |
I messed up adding to your PR @kastoestoramadus
See #438
Just looking into this and rendering is a very popular topic and never tackled. I think we need to review and be confident we are not getting into a can of worms unless you plan to help me on some of the render issues and requests.
I am still leaning towards accepting this PR but would like you thought on some of the issues raised and other issues and PRs already brought up.
PRs
Issues
Search
https://github.com/lightbend/config/issues?q=is%3Aissue%20state%3Aopen%20render