-
Notifications
You must be signed in to change notification settings - Fork 9
Making rendering useful for formatting files. #438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@kastoestoramadus Thanks for this pull request. I will work with you to try and understand this improvement and get it to the finish line. You will need to run
|
840e071
to
2e0a15a
Compare
2e0a15a
to
6622364
Compare
} | ||
|
||
@Test | ||
def keepOriginOrderOfEntries(): Unit = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ekrich
Before, entries always were sorted in alphabetical order.
with
- ConfigFactory.parseFile
- render
- and save to file
a formatter is ready to go.
sconfig/shared/src/test/scala/org/ekrich/config/impl/FormattingOptionsTest.scala
Outdated
Show resolved
Hide resolved
@@ -79,7 +81,7 @@ object SimpleConfigObject { | |||
} | |||
|
|||
@SerialVersionUID(1L) | |||
final private class RenderComparator | |||
private class RenderComparator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure where this guarantee is used.
What rule does my new comparator have to obey?
@kastoestoramadus I was wondering if you could answer the questions I asked before. I do this part time so I don't have much time to devote to major changes.
Note: In the history of this library - This is a very stable library. I would like to improve it but I have to be very careful to not break binary compatibility. A couple of your changes potentially break compatibility. I have To check run: |
hi, I'll check this Do you share this mima somewhere? |
If render was only for debugging then my changes shouldn't be risky to add as a new production feature to it as long, as it get parsed back to the same model ;). |
Closed via #454 |
Added:
Why? lack of good formatter that can be used with git hooks. This lib allows ignoring resolving the references.