Skip to content

Travis-CI: test on JDK 11, too #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Travis-CI: test on JDK 11, too #41

wants to merge 1 commit into from

Conversation

SethTisue
Copy link
Contributor

@SethTisue SethTisue commented Jul 29, 2019 •
edited
Loading

in the Scala 2.13 community build, I'm seeing JDK 11 only test failures

[error] Failed: Total 530, Failed 14, Errors 0, Passed 516
[error] Failed tests:
[error] 	ApiExamples
[error] 	org.ekrich.config.impl.PublicApiTest
[error] 	org.ekrich.config.impl.ConfigTest

I think they'll show up here as well, with this Travis-CI config change

@ekrich
Copy link
Owner

ekrich commented Jul 29, 2019 •
edited
Loading

@SethTisue Thanks for this PR. This looks like a good way forward.

I have found the fix needed for jdk11 and started a PR - #42
I still am having some issues on Scala Native. Maybe you have some insight.

[info] Linking (8997 ms)
[error] cannot link: @java.util.ArrayList::hashCode_i32
[warn] bootstrap class path not set in conjunction with -source 8

The second part could be related to the first. I have the following in the build.
https://github.com/ekrich/sconfig/blob/master/build.sbt#L93-L98

This too on JVM. Edit: the WARNING below has been fixed in sbt 1.3.

WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by sbt.internal.inc.javac.DiagnosticsReporter$PositionImpl$ (file:/Users/eric/.sbt/boot/scala-2.12.7/org.scala-sbt/sbt/1.2.8/zinc-compile-core_2.12-1.2.5.jar) to field com.sun.tools.javac.api.ClientCodeWrapper$DiagnosticSourceUnwrapper.d
WARNING: Please consider reporting this to the maintainers of sbt.internal.inc.javac.DiagnosticsReporter$PositionImpl$
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release
[warn] bootstrap class path not set in conjunction with -source 8

@SethTisue
Copy link
Contributor Author

The "illegal reflective access" warnings you can ignore (probably they are already fixed in sbt 1.3.0-RC3?).

I don't have any insight into the Scala Native thing. Perhaps it would better to redo the CI matrix so that the Scala Native part of the build stays JDK 8 only for now.

@ekrich
Copy link
Owner

ekrich commented Jul 29, 2019

I'm not sure of the source, but Scala Native is not cooperating now. scala-native/scala-native#1675

ekrich
ekrich requested changes Jul 30, 2019
View reviewed changes
Copy link
Owner

@ekrich ekrich left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On this line 1c4e0ad#diff-354f30a63fb0907d4ad57269548329e3R31 we could avoid Native testing by changing +test to +sconfigJVM/test +sconfigJS/test. Edit: forget second + sign.

@SethTisue
Copy link
Contributor Author

can you take this PR over? feel free to force-push your own stuff, or just close it and make a new one

@ekrich
Copy link
Owner

ekrich commented Jul 31, 2019

@SethTisue I really appreciate the thought you put into it. Pretty sure we will have jdk11 support shortly thanks to your effort and prodding.

@ekrich ekrich mentioned this pull request Jul 31, 2019
Merged
@ekrich
Copy link
Owner

ekrich commented Jul 31, 2019

Continued here: #43

@ekrich ekrich closed this Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekrich ekrich ekrich requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SethTisue @ekrich