Skip to content

[0.3.x] Add override to allow sconfig to link #1675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[0.3.x] Add override to allow sconfig to link #1675

wants to merge 1 commit into from

Conversation

ekrich
Copy link
Member

@ekrich ekrich commented Jul 29, 2019

I am working on jdk11 support for sconfig and this is now causing problems.

[info] Compiling 1 Scala source to /Users/eric/workspace/sconfig/sconfig/native/target/scala-2.11/test-classes ...
[info] Done compiling.
[info] Linking (8622 ms)
[error] cannot link: @java.util.ArrayList::hashCode_i32
[error] unable to link
[error] (sconfigNative / Nativetest / nativeLink) unable to link

I thought maybe it was related to 2.13 collection compat code but not sure now. This does solve the issue.

@LeeTibbert
Copy link
Contributor

I think the usual recommendation is to override equals() and hashcode() together.
I think that you could do just hashcode() here, for our use, but that would leave a reader
wondering if equals() used the same fields and where the override for it is.

@ekrich
Copy link
Member Author

ekrich commented Jul 29, 2019

So far I have only added things that don't work. This is a new requirement for sconfig at this point. Changes block me from improving and changing the library.

This was referenced Jul 29, 2019
Closed
Closed
@ekrich
Copy link
Member Author

ekrich commented Oct 9, 2019

@densh Any chance this could get merged and we could get a 0.3.10 release? I know nobody is really asking for any fixes but I am still trying to build better support and this would fix the JDK11 support along with the other changes on this branch.

@ekrich
Copy link
Member Author

ekrich commented Jun 9, 2020

The sconfig library has dropped 0.3.x support in the newest versions.

@ekrich ekrich closed this Jun 9, 2020
@ekrich ekrich deleted the topic/arraylist branch February 12, 2021 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ekrich @LeeTibbert