Skip to content

Support create cluster default addon metrics-server #8118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 9, 2025
Merged

Support create cluster default addon metrics-server #8118

merged 2 commits into from
Jan 9, 2025

Conversation

gustavodiaz7722
Copy link
Contributor

@gustavodiaz7722 gustavodiaz7722 commented Jan 8, 2025 •
edited
Loading

Description

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@gustavodiaz7722 gustavodiaz7722 added the kind/feature New feature or request label Jan 8, 2025
@gustavodiaz7722
Copy link
Contributor Author

Manually tested using following procedure

  1. create cluster using eksctl default addonseksctl create cluster
  2. Verify metrics-server created on cluster using aws cli aws eks list-addons --cluster-name
  3. Verify metrics-server becomes active on cluster using aws cli aws eks describe-addon --addon-name metrics-server --cluster-name

@gustavodiaz7722 gustavodiaz7722 merged commit 905e6e9 into eksctl-io:main Jan 9, 2025
9 checks passed
@eksctl-bot eksctl-bot mentioned this pull request Jan 9, 2025
Merged
@gustavodiaz7722 gustavodiaz7722 deleted the feature/metrics-server branch January 13, 2025 19:57
@eksctl-bot eksctl-bot mentioned this pull request Jan 14, 2025
Merged
@jhcook
Copy link

jhcook commented Jan 17, 2025

This merge is not documented and has broken our deployments. Thanks.

https://eksctl.io/usage/addons/

@jpf-okteto jpf-okteto mentioned this pull request Jun 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@TiberiuGC TiberiuGC TiberiuGC approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
kind/feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gustavodiaz7722 @jhcook @TiberiuGC