Skip to content

add indent_size for tsx in .editorconfig #11380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 5, 2022
Merged

add indent_size for tsx in .editorconfig #11380

merged 1 commit into from
Jul 5, 2022

Conversation

yiliang114
Copy link
Contributor

Signed-off-by: yiliang114 1204183885@qq.com

What it does

  1. set the indent size of tsx file 4.

How to test

  1. open theia source code in editor such as vscode or webstorm.
  2. open any tsx file, change and save
  3. eslint will not make this tsx file to be 2 indent_size.

Review checklist

Reminder for reviewers

@yiliang114
add tsx to .editorconfig
4a58597 
Signed-off-by: yiliang114 <1204183885@qq.com>
@yiliang114
Copy link
Contributor Author

If not, it will cause such problem when we trigger autoFixOnSave

image

@colin-grant-work colin-grant-work self-requested a review July 5, 2022 15:09
colin-grant-work
colin-grant-work approved these changes Jul 5, 2022
View reviewed changes
Copy link
Contributor

@colin-grant-work colin-grant-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. 👍

@colin-grant-work colin-grant-work merged commit 97ce5f8 into eclipse-theia:master Jul 5, 2022
@vince-fugnitto vince-fugnitto added the contributor experience issues related to the contributor experience label Jul 28, 2022
@vince-fugnitto vince-fugnitto added this to the 1.28.0 milestone Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-grant-work colin-grant-work colin-grant-work approved these changes

Assignees
No one assigned
Labels
contributor experience issues related to the contributor experience
Projects
None yet
Milestone
1.28.0
Development

Successfully merging this pull request may close these issues.
3 participants
@yiliang114 @colin-grant-work @vince-fugnitto