Skip to content

Align focused button outline to vscode #11192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 24, 2022
Merged

Align focused button outline to vscode #11192

merged 1 commit into from
May 24, 2022

Conversation

msujew
Copy link
Member

@msujew msujew commented May 23, 2022

What it does

Closes #11191

Removes box shadows, etc. from theia-button elements and adds an outline instead

How to test

  1. Open a dialog by - for example - trying to delete a file.
  2. Assert that the buttons behave as in vscode in regards to hover/focus behavior.

Review checklist

Reminder for reviewers

@msujew msujew added the ui/ux issues related to user interface / user experience label May 23, 2022
@colin-grant-work colin-grant-work self-requested a review May 23, 2022 15:02
@colin-grant-work colin-grant-work mentioned this pull request May 23, 2022
Closed
7 tasks
colin-grant-work
colin-grant-work approved these changes May 23, 2022
View reviewed changes
Copy link
Contributor

@colin-grant-work colin-grant-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me. They are consistent with VSCode (browser), and produce no regressions in the highlighting of buttons in different contexts.

@msujew msujew merged commit a413e17 into master May 24, 2022
@msujew msujew deleted the msujew/css-button-focus branch May 24, 2022 10:20
@github-actions github-actions bot added this to the 1.26.0 milestone May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-grant-work colin-grant-work colin-grant-work approved these changes

Assignees
No one assigned
Labels
ui/ux issues related to user interface / user experience
Projects
None yet
Milestone
1.26.0
Development

Successfully merging this pull request may close these issues.

Apply correct focus for buttons
2 participants
@msujew @colin-grant-work