Skip to content

Changing escape quoting #730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Changing escape quoting #730

wants to merge 2 commits into from

Conversation

MartinFillon
Copy link
Contributor

As mentioned in #728

@MartinFillon MartinFillon self-assigned this Dec 17, 2023
@John-Gee
Copy link

Thanks for working on this so quickly!

PThorpe92
PThorpe92 requested changes Dec 18, 2023
View reviewed changes
@MartinFillon MartinFillon force-pushed the changing-escape-quoting branch from 6f63e9c to 86b7223 Compare December 19, 2023 20:53
@MartinFillon MartinFillon force-pushed the changing-escape-quoting branch from 86b7223 to 6cc754d Compare December 19, 2023 20:56
PThorpe92
PThorpe92 previously approved these changes Dec 20, 2023
View reviewed changes
@MartinFillon MartinFillon force-pushed the changing-escape-quoting branch from c93e2b4 to ef099c0 Compare January 30, 2024 07:55
@MartinFillon MartinFillon force-pushed the changing-escape-quoting branch from ef099c0 to cb99bc9 Compare January 30, 2024 07:59
cafkafk
cafkafk requested changes Mar 3, 2024
View reviewed changes
Copy link
Member

@cafkafk cafkafk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you resolve the conflicts, seems like it's just those test changes

@MartinFillon
Copy link
Contributor Author

Gonna take a look later when I have time

Omnikron13 pushed a commit to Omnikron13/eza that referenced this pull request Mar 17, 2024
@alpn @Omnikron13
Add SubdirGitRepo and SubdirGitRepoStatus types (eza-community#730)
54a11f6 
	modified:   src/fs/fields.rs
Omnikron13 pushed a commit to Omnikron13/eza that referenced this pull request Mar 17, 2024
@alpn @Omnikron13
Add render() implementation for SubdirGitRepo (eza-community#730)
0dd9359 
	modified:   src/output/render/git.rs
Omnikron13 pushed a commit to Omnikron13/eza that referenced this pull request Mar 17, 2024
@alpn @Omnikron13
Add SubdirGitRepo::from_path() (eza-community#730)
3c0aa1a 
	modified:   src/fs/feature/git.rs
@cafkafk cafkafk requested a review from gierens as a code owner January 16, 2025 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cafkafk cafkafk cafkafk requested changes

@PThorpe92 PThorpe92 PThorpe92 left review comments

@gierens gierens Awaiting requested review from gierens gierens is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@MartinFillon MartinFillon

Labels
features › ui
Projects
No open projects
Eza Pull-Requests
Status: 🔖 Ready
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MartinFillon @John-Gee @cafkafk @PThorpe92