feat: add node budget and memory limits #762
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement compile-time and runtime safeguards against deeply nested expressions: - Add MaxNodes limit to track and limit AST node count during parsing - Move MemoryBudget from VM to Config for better configurability - Add node creation tracking in parser to enforce node budget - Refactor node creation to check limits before allocation - Add RunWithConfig to VM for passing memory budget settings - Set reasonable defaults in Config (10000 nodes, 1M memory) - Add comprehensive tests for both node and memory limits This prevents stack overflows from malicious or poorly written expressions by failing fast with clear error messages during compilation or runtime. Signed-off-by: Ville Vesilehto <ville@vesilehto.fi>
|
Just tested with 50k nodes. Execution time is just So, the problem arises only in input program length is not restricted. |
Signed-off-by: Anton Medvedev <anton@medv.io>
antonmedv
reviewed
Mar 7, 2025
This was referenced Mar 24, 2025
SimFG
pushed a commit
to SimFG/expr
that referenced
this pull request
Apr 15, 2025
* feat: add node budget and memory limits Implement compile-time and runtime safeguards against deeply nested expressions: - Add MaxNodes limit to track and limit AST node count during parsing - Move MemoryBudget from VM to Config for better configurability - Add node creation tracking in parser to enforce node budget - Refactor node creation to check limits before allocation - Add RunWithConfig to VM for passing memory budget settings - Set reasonable defaults in Config (10000 nodes, 1M memory) - Add comprehensive tests for both node and memory limits This prevents stack overflows from malicious or poorly written expressions by failing fast with clear error messages during compilation or runtime. Signed-off-by: Ville Vesilehto <ville@vesilehto.fi> * Update parser.go Signed-off-by: Anton Medvedev <anton@medv.io> --------- Signed-off-by: Ville Vesilehto <ville@vesilehto.fi> Signed-off-by: Anton Medvedev <anton@medv.io> Co-authored-by: Anton Medvedev <anton@medv.io>
SimFG
pushed a commit
to SimFG/expr
that referenced
this pull request
May 13, 2025
* feat: add node budget and memory limits Implement compile-time and runtime safeguards against deeply nested expressions: - Add MaxNodes limit to track and limit AST node count during parsing - Move MemoryBudget from VM to Config for better configurability - Add node creation tracking in parser to enforce node budget - Refactor node creation to check limits before allocation - Add RunWithConfig to VM for passing memory budget settings - Set reasonable defaults in Config (10000 nodes, 1M memory) - Add comprehensive tests for both node and memory limits This prevents stack overflows from malicious or poorly written expressions by failing fast with clear error messages during compilation or runtime. Signed-off-by: Ville Vesilehto <ville@vesilehto.fi> * Update parser.go Signed-off-by: Anton Medvedev <anton@medv.io> --------- Signed-off-by: Ville Vesilehto <ville@vesilehto.fi> Signed-off-by: Anton Medvedev <anton@medv.io> Co-authored-by: Anton Medvedev <anton@medv.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement compile-time and runtime safeguards against deeply nested expressions:
This prevents stack overflows from malicious or poorly written expressions by failing fast with clear error messages during compilation or runtime.