Skip to content

Conversation

EvanBacon
Copy link
Contributor

Why

  • Readme said we'd remove this in SDK 47.
  • Deprecated originally because expo-updates uses its own version of expo-error-recovery.

How

  • Deleted a bunch of references to expo-error-recovery.

Test Plan

  • tbd

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Feb 9, 2023
@wschurman wschurman removed their request for review February 9, 2023 18:04
Copy link
Contributor

@douglowder douglowder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates E2E works with these changes

@Simek
Copy link
Contributor

Simek commented Feb 13, 2023

Do we have the archive repo created (since we remove all package related files)?

Refs discussion in:

@expo-bot
Copy link
Collaborator

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them for more details) 👇

⚠️ Suggestion: Missing changelog entries


Your changes should be noted in the changelog. Read Updating Changelogs guide and consider adding an appropriate entry to the following changelogs:


Generated by ExpoBot 🤖 against d549439

@EvanBacon EvanBacon merged commit 87ffd74 into main Feb 13, 2023
@EvanBacon EvanBacon deleted the @evanbacon/error-recovery/deprecate branch February 13, 2023 23:33
tsapeta pushed a commit that referenced this pull request Feb 14, 2023
# Why

- Readme said we'd remove this in SDK 47.
- Deprecated originally because expo-updates uses its own version of
expo-error-recovery.

# How

- Deleted a bunch of references to expo-error-recovery.

# Test Plan

- tbd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: suggestions ExpoBot has some suggestions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants