[#18077] [expo-sqlite] Support nulls in query args #18078
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng in the test suite!)
…dy passing in the test suite!)" This reverts commit 85ad615.
|
The test suite errors look to my eyes like red herrings. But caveat: I haven't contributed to this repo before. But on all three platforms the failure is the same: the |
|
Thanks @bbarthec ! How often do you reelase new version of |
|
@tsheaff, I believe |
3 tasks
Kudo
pushed a commit
that referenced
this pull request
Nov 10, 2023
# Why #18078 fixed this for the callback-based functions, but not for `executeSqlAsync`. Changing the parameters for the `args` of that function to match.
onizam95
pushed a commit
to onizam95/expo-av-drm
that referenced
this pull request
Jan 15, 2024
# Why expo#18078 fixed this for the callback-based functions, but not for `executeSqlAsync`. Changing the parameters for the `args` of that function to match.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Please see #18077 for full motivation
How
Update the types of
executeSql > argsparam from(number | string)[]to(number | string | null)[]Test Plan
There is already a test passing for this behavior in the test suite! See here. This test is in JS not TS, so no issue was raised on the type mismatch.
Checklist
expo build(eg: updated@expo/xdl).expo prebuild& EAS Build (eg: updated a module plugin).