[bare-expo] Use official react-native #15817
Merged
+146
−132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ENG-2234 Stop using our forked react-native in bare-expo
since we stopped using forked react-native in bare templates, we should also consistently do it in bare-expo. |
Kudo
commented
Jan 6, 2022
apps/bare-expo/ios/Podfile.lock
Outdated
| @@ -1338,7 +1338,7 @@ SPEC CHECKSUMS: | |||
| EXWebBrowser: 37388663fa51cbfc883de2244931a5182d948e5f | |||
| FacebookSDK: 4b9bb8e2824898b47f18c666dc145c09b40609e6 | |||
| FBLazyVector: c71c5917ec0ad2de41d5d06a5855f6d5eda06971 | |||
| FBReactNativeSpec: 289039c27ca26d02a6683c56c6fc7868bc804c43 | |||
| FBReactNativeSpec: 8758eb0003171e03e3bb263e52848cf4286fe30d | |||
There was a problem hiding this comment.
oh no, this cherry-pick does matter: expo/react-native@f21d982
i need to find a way to deal with the unstable hash
Kudo
commented
Jan 10, 2022
| const copyFiles = ['scripts/generate-specs.sh', 'scripts/react_native_pods.rb']; | ||
| for (const file of copyFiles) { | ||
| fs.copyFileSync(path.join(expoRNRoot, file), path.join(nodeModulesRNRoot, file)); | ||
| } |
There was a problem hiding this comment.
it's worth to pay attention to this workaround script. @tsapeta could you help to review again when you get a chance?
There was a problem hiding this comment.
I think that's fine. On the other side, I think that we should maybe try to upgrade RN in the repository right now to 0.66, before the release.
If we would upgrade to 0.67 in SDK45, it would be a pain to go from 64 to 67 at once. Also, I'll feel more confident if we test our modules against newer versions, rather than waiting until April 🤔
There was a problem hiding this comment.
it's worth to try. i'll merge this first and do some trial on 66 upgrade this week.
tsapeta
approved these changes
Jan 10, 2022
Kudo
added a commit
that referenced
this pull request
Jan 20, 2022
# Why follow up #15817 (comment) after we use the react-native from npm, the react-native version we used in expo-go is decoupled with other stuffs. that makes us upgrade react-native easier. # How 1. update versions in package.json 2. sync changes from [react-native-upgrade-helper](https://react-native-community.github.io/upgrade-helper/?from=0.64.2&to=0.66.4) 3. `RCTComponentData` changed its designated initializer in react-native 0.65. to make it compatible with older version, i introduced the `EXComponentDataCompatibleWrapper` class to support different versions. 4. [react-native-lab] to fix expo-go build error, we should patch react-native to use the codegen library from its repo but not from node_modules: expo/react-native#29. # Test Plan - CI passed - bare-expo build & launch test - unversioned expo-go build & launch test
prakashbask
pushed a commit
to prakashbask/expo
that referenced
this pull request
Mar 16, 2022
# Why follow up expo#15817 (comment) after we use the react-native from npm, the react-native version we used in expo-go is decoupled with other stuffs. that makes us upgrade react-native easier. # How 1. update versions in package.json 2. sync changes from [react-native-upgrade-helper](https://react-native-community.github.io/upgrade-helper/?from=0.64.2&to=0.66.4) 3. `RCTComponentData` changed its designated initializer in react-native 0.65. to make it compatible with older version, i introduced the `EXComponentDataCompatibleWrapper` class to support different versions. 4. [react-native-lab] to fix expo-go build error, we should patch react-native to use the codegen library from its repo but not from node_modules: expo/react-native#29. # Test Plan - CI passed - bare-expo build & launch test - unversioned expo-go build & launch test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
from sdk 43, we've tried to use official react-native in our bare template. that would be good if we do this also in bare-expo and our tests will be more like a real app which user would have. this change will also reduce android CI time because we don't need to build react-native AAR. (test-suite android from about 30m -> 23m)
close ENG-2234
How
react-native-lab/react-nativefrom yarn workspacethe only purpose of
react-native-lab/react-nativeis for expo-go versioned code after this pr.Test Plan
et remove-sdk -p {android,ios} -s 44.0.0 ; et add-sdk -p {android,ios} -s 44.0.0and check versioning rightChecklist
expo build(eg: updated@expo/xdl).expo prebuild& EAS Build (eg: updated a module plugin).