[expo-go] add reload command for simulator builds only #14735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsapeta
approved these changes
Oct 14, 2021
brentvatne
pushed a commit
that referenced
this pull request
Oct 14, 2021
Kudo
added a commit
to expo/react-native
that referenced
this pull request
Apr 26, 2022
RCTKeyCommands uses iOS private symbols to hook keyboard commands. originally it's debug build only, however, we enable `RCT_DEV` in Expo Go even on release build. this change updates the functionalities for simulator build only which aligns to expo/expo#14735.
Kudo
added a commit
to expo/react-native
that referenced
this pull request
Apr 26, 2022
RCTKeyCommands uses iOS private symbols to hook keyboard commands. originally it's debug build only, however, we enable `RCT_DEV` in Expo Go even on release build. this change updates the functionalities for simulator build only which aligns to expo/expo#14735.
Kudo
added a commit
to expo/react-native
that referenced
this pull request
May 13, 2022
RCTKeyCommands uses iOS private symbols to hook keyboard commands. originally it's debug build only, however, we enable `RCT_DEV` in Expo Go even on release build. this change updates the functionalities for simulator build only which aligns to expo/expo#14735.
douglowder
pushed a commit
to react-native-tvos/react-native-tvos
that referenced
this pull request
May 23, 2022
RCTKeyCommands uses iOS private symbols to hook keyboard commands. originally it's debug build only, however, we enable `RCT_DEV` in Expo Go even on release build. this change updates the functionalities for simulator build only which aligns to expo/expo#14735.
Kudo
added a commit
to expo/react-native
that referenced
this pull request
May 24, 2022
RCTKeyCommands uses iOS private symbols to hook keyboard commands. originally it's debug build only, however, we enable `RCT_DEV` in Expo Go even on release build. this change updates the functionalities for simulator build only which aligns to expo/expo#14735.
Kudo
added a commit
to expo/react-native
that referenced
this pull request
Jun 23, 2022
RCTKeyCommands uses iOS private symbols to hook keyboard commands. originally it's debug build only, however, we enable `RCT_DEV` in Expo Go even on release build. this change updates the functionalities for simulator build only which aligns to expo/expo#14735.
Kudo
added a commit
to expo/react-native
that referenced
this pull request
Jun 29, 2022
RCTKeyCommands uses iOS private symbols to hook keyboard commands. originally it's debug build only, however, we enable `RCT_DEV` in Expo Go even on release build. this change updates the functionalities for simulator build only which aligns to expo/expo#14735.
Kudo
added a commit
to expo/react-native
that referenced
this pull request
Sep 27, 2022
RCTKeyCommands uses iOS private symbols to hook keyboard commands. originally it's debug build only, however, we enable `RCT_DEV` in Expo Go even on release build. this change updates the functionalities for simulator build only which aligns to expo/expo#14735.
Kudo
added a commit
to expo/react-native
that referenced
this pull request
Oct 4, 2022
RCTKeyCommands uses iOS private symbols to hook keyboard commands. originally it's debug build only, however, we enable `RCT_DEV` in Expo Go even on release build. this change updates the functionalities for simulator build only which aligns to expo/expo#14735.
Kudo
added a commit
to expo/react-native
that referenced
this pull request
Oct 13, 2022
RCTKeyCommands uses iOS private symbols to hook keyboard commands. originally it's debug build only, however, we enable `RCT_DEV` in Expo Go even on release build. this change updates the functionalities for simulator build only which aligns to expo/expo#14735.
Kudo
added a commit
to expo/react-native
that referenced
this pull request
Jan 9, 2023
RCTKeyCommands uses iOS private symbols to hook keyboard commands. originally it's debug build only, however, we enable `RCT_DEV` in Expo Go even on release build. this change updates the functionalities for simulator build only which aligns to expo/expo#14735.
Kudo
added a commit
to expo/react-native
that referenced
this pull request
Jan 12, 2023
RCTKeyCommands uses iOS private symbols to hook keyboard commands. originally it's debug build only, however, we enable `RCT_DEV` in Expo Go even on release build. this change updates the functionalities for simulator build only which aligns to expo/expo#14735.
Kudo
added a commit
to expo/react-native
that referenced
this pull request
Feb 1, 2023
RCTKeyCommands uses iOS private symbols to hook keyboard commands. originally it's debug build only, however, we enable `RCT_DEV` in Expo Go even on release build. this change updates the functionalities for simulator build only which aligns to expo/expo#14735.
Kudo
added a commit
to expo/react-native
that referenced
this pull request
May 21, 2023
RCTKeyCommands uses iOS private symbols to hook keyboard commands. originally it's debug build only, however, we enable `RCT_DEV` in Expo Go even on release build. this change updates the functionalities for simulator build only which aligns to expo/expo#14735. (cherry picked from commit 522d724)
Kudo
added a commit
to expo/react-native
that referenced
this pull request
Jun 1, 2023
RCTKeyCommands uses iOS private symbols to hook keyboard commands. originally it's debug build only, however, we enable `RCT_DEV` in Expo Go even on release build. this change updates the functionalities for simulator build only which aligns to expo/expo#14735.
Kudo
added a commit
to expo/react-native
that referenced
this pull request
Jun 21, 2023
RCTKeyCommands uses iOS private symbols to hook keyboard commands. originally it's debug build only, however, we enable `RCT_DEV` in Expo Go even on release build. this change updates the functionalities for simulator build only which aligns to expo/expo#14735.
gabrieldonadel
pushed a commit
to expo/react-native
that referenced
this pull request
Oct 19, 2023
RCTKeyCommands uses iOS private symbols to hook keyboard commands. originally it's debug build only, however, we enable `RCT_DEV` in Expo Go even on release build. this change updates the functionalities for simulator build only which aligns to expo/expo#14735.
gabrieldonadel
pushed a commit
to expo/react-native
that referenced
this pull request
Oct 25, 2023
RCTKeyCommands uses iOS private symbols to hook keyboard commands. originally it's debug build only, however, we enable `RCT_DEV` in Expo Go even on release build. this change updates the functionalities for simulator build only which aligns to expo/expo#14735.
gabrieldonadel
pushed a commit
to expo/react-native
that referenced
this pull request
Nov 7, 2023
RCTKeyCommands uses iOS private symbols to hook keyboard commands. originally it's debug build only, however, we enable `RCT_DEV` in Expo Go even on release build. this change updates the functionalities for simulator build only which aligns to expo/expo#14735.
gabrieldonadel
pushed a commit
to expo/react-native
that referenced
this pull request
Nov 13, 2023
RCTKeyCommands uses iOS private symbols to hook keyboard commands. originally it's debug build only, however, we enable `RCT_DEV` in Expo Go even on release build. this change updates the functionalities for simulator build only which aligns to expo/expo#14735.
gabrieldonadel
pushed a commit
to expo/react-native
that referenced
this pull request
Nov 20, 2023
RCTKeyCommands uses iOS private symbols to hook keyboard commands. originally it's debug build only, however, we enable `RCT_DEV` in Expo Go even on release build. this change updates the functionalities for simulator build only which aligns to expo/expo#14735.
gabrieldonadel
pushed a commit
to expo/react-native
that referenced
this pull request
Feb 6, 2025
RCTKeyCommands uses iOS private symbols to hook keyboard commands. originally it's debug build only, however, we enable `RCT_DEV` in Expo Go even on release build. this change updates the functionalities for simulator build only which aligns to expo/expo#14735.
vonovak
pushed a commit
to expo/react-native
that referenced
this pull request
Feb 21, 2025
RCTKeyCommands uses iOS private symbols to hook keyboard commands. originally it's debug build only, however, we enable `RCT_DEV` in Expo Go even on release build. this change updates the functionalities for simulator build only which aligns to expo/expo#14735.
vonovak
pushed a commit
to expo/react-native
that referenced
this pull request
Feb 21, 2025
RCTKeyCommands uses iOS private symbols to hook keyboard commands. originally it's debug build only, however, we enable `RCT_DEV` in Expo Go even on release build. this change updates the functionalities for simulator build only which aligns to expo/expo#14735.
vonovak
pushed a commit
to expo/react-native
that referenced
this pull request
Feb 25, 2025
RCTKeyCommands uses iOS private symbols to hook keyboard commands. originally it's debug build only, however, we enable `RCT_DEV` in Expo Go even on release build. this change updates the functionalities for simulator build only which aligns to expo/expo#14735.
alanjhughes
pushed a commit
to expo/react-native
that referenced
this pull request
Mar 7, 2025
RCTKeyCommands uses iOS private symbols to hook keyboard commands. originally it's debug build only, however, we enable `RCT_DEV` in Expo Go even on release build. this change updates the functionalities for simulator build only which aligns to expo/expo#14735.
alanjhughes
pushed a commit
to expo/react-native
that referenced
this pull request
Mar 14, 2025
RCTKeyCommands uses iOS private symbols to hook keyboard commands. originally it's debug build only, however, we enable `RCT_DEV` in Expo Go even on release build. this change updates the functionalities for simulator build only which aligns to expo/expo#14735.
alanjhughes
pushed a commit
to expo/react-native
that referenced
this pull request
Mar 18, 2025
RCTKeyCommands uses iOS private symbols to hook keyboard commands. originally it's debug build only, however, we enable `RCT_DEV` in Expo Go even on release build. this change updates the functionalities for simulator build only which aligns to expo/expo#14735.
alanjhughes
pushed a commit
to expo/react-native
that referenced
this pull request
Mar 25, 2025
RCTKeyCommands uses iOS private symbols to hook keyboard commands. originally it's debug build only, however, we enable `RCT_DEV` in Expo Go even on release build. this change updates the functionalities for simulator build only which aligns to expo/expo#14735.
gabrieldonadel
pushed a commit
to expo/react-native
that referenced
this pull request
Mar 26, 2025
RCTKeyCommands uses iOS private symbols to hook keyboard commands. originally it's debug build only, however, we enable `RCT_DEV` in Expo Go even on release build. this change updates the functionalities for simulator build only which aligns to expo/expo#14735.
alanjhughes
pushed a commit
to expo/react-native
that referenced
this pull request
Apr 1, 2025
RCTKeyCommands uses iOS private symbols to hook keyboard commands. originally it's debug build only, however, we enable `RCT_DEV` in Expo Go even on release build. this change updates the functionalities for simulator build only which aligns to expo/expo#14735.
gabrieldonadel
pushed a commit
to expo/react-native
that referenced
this pull request
Apr 3, 2025
RCTKeyCommands uses iOS private symbols to hook keyboard commands. originally it's debug build only, however, we enable `RCT_DEV` in Expo Go even on release build. this change updates the functionalities for simulator build only which aligns to expo/expo#14735.
alanjhughes
pushed a commit
to expo/react-native
that referenced
this pull request
Apr 8, 2025
RCTKeyCommands uses iOS private symbols to hook keyboard commands. originally it's debug build only, however, we enable `RCT_DEV` in Expo Go even on release build. this change updates the functionalities for simulator build only which aligns to expo/expo#14735.
alanjhughes
pushed a commit
to expo/react-native
that referenced
this pull request
Apr 15, 2025
RCTKeyCommands uses iOS private symbols to hook keyboard commands. originally it's debug build only, however, we enable `RCT_DEV` in Expo Go even on release build. this change updates the functionalities for simulator build only which aligns to expo/expo#14735.
alanjhughes
pushed a commit
to expo/react-native
that referenced
this pull request
May 1, 2025
RCTKeyCommands uses iOS private symbols to hook keyboard commands. originally it's debug build only, however, we enable `RCT_DEV` in Expo Go even on release build. this change updates the functionalities for simulator build only which aligns to expo/expo#14735.
chrfalch
pushed a commit
to expo/react-native
that referenced
this pull request
Jun 2, 2025
RCTKeyCommands uses iOS private symbols to hook keyboard commands. originally it's debug build only, however, we enable `RCT_DEV` in Expo Go even on release build. this change updates the functionalities for simulator build only which aligns to expo/expo#14735.
gabrieldonadel
pushed a commit
to expo/react-native
that referenced
this pull request
Jun 4, 2025
RCTKeyCommands uses iOS private symbols to hook keyboard commands. originally it's debug build only, however, we enable `RCT_DEV` in Expo Go even on release build. this change updates the functionalities for simulator build only which aligns to expo/expo#14735.
gabrieldonadel
pushed a commit
to expo/react-native
that referenced
this pull request
Jun 5, 2025
RCTKeyCommands uses iOS private symbols to hook keyboard commands. originally it's debug build only, however, we enable `RCT_DEV` in Expo Go even on release build. this change updates the functionalities for simulator build only which aligns to expo/expo#14735.
gabrieldonadel
pushed a commit
to expo/react-native
that referenced
this pull request
Jun 9, 2025
RCTKeyCommands uses iOS private symbols to hook keyboard commands. originally it's debug build only, however, we enable `RCT_DEV` in Expo Go even on release build. this change updates the functionalities for simulator build only which aligns to expo/expo#14735.
gabrieldonadel
pushed a commit
to expo/react-native
that referenced
this pull request
Jun 12, 2025
RCTKeyCommands uses iOS private symbols to hook keyboard commands. originally it's debug build only, however, we enable `RCT_DEV` in Expo Go even on release build. this change updates the functionalities for simulator build only which aligns to expo/expo#14735.
gabrieldonadel
pushed a commit
to expo/react-native
that referenced
this pull request
Jun 18, 2025
RCTKeyCommands uses iOS private symbols to hook keyboard commands. originally it's debug build only, however, we enable `RCT_DEV` in Expo Go even on release build. this change updates the functionalities for simulator build only which aligns to expo/expo#14735.
gabrieldonadel
pushed a commit
to expo/react-native
that referenced
this pull request
Jun 18, 2025
RCTKeyCommands uses iOS private symbols to hook keyboard commands. originally it's debug build only, however, we enable `RCT_DEV` in Expo Go even on release build. this change updates the functionalities for simulator build only which aligns to expo/expo#14735.
gabrieldonadel
pushed a commit
to expo/react-native
that referenced
this pull request
Jul 1, 2025
RCTKeyCommands uses iOS private symbols to hook keyboard commands. originally it's debug build only, however, we enable `RCT_DEV` in Expo Go even on release build. this change updates the functionalities for simulator build only which aligns to expo/expo#14735.
gabrieldonadel
pushed a commit
to expo/react-native
that referenced
this pull request
Jul 1, 2025
RCTKeyCommands uses iOS private symbols to hook keyboard commands. originally it's debug build only, however, we enable `RCT_DEV` in Expo Go even on release build. this change updates the functionalities for simulator build only which aligns to expo/expo#14735.
gabrieldonadel
pushed a commit
to expo/react-native
that referenced
this pull request
Jul 1, 2025
RCTKeyCommands uses iOS private symbols to hook keyboard commands. originally it's debug build only, however, we enable `RCT_DEV` in Expo Go even on release build. this change updates the functionalities for simulator build only which aligns to expo/expo#14735.
gabrieldonadel
pushed a commit
to expo/react-native
that referenced
this pull request
Jul 31, 2025
RCTKeyCommands uses iOS private symbols to hook keyboard commands. originally it's debug build only, however, we enable `RCT_DEV` in Expo Go even on release build. this change updates the functionalities for simulator build only which aligns to expo/expo#14735.
gabrieldonadel
pushed a commit
to expo/react-native
that referenced
this pull request
Jul 31, 2025
RCTKeyCommands uses iOS private symbols to hook keyboard commands. originally it's debug build only, however, we enable `RCT_DEV` in Expo Go even on release build. this change updates the functionalities for simulator build only which aligns to expo/expo#14735.
gabrieldonadel
pushed a commit
to expo/react-native
that referenced
this pull request
Aug 5, 2025
RCTKeyCommands uses iOS private symbols to hook keyboard commands. originally it's debug build only, however, we enable `RCT_DEV` in Expo Go even on release build. this change updates the functionalities for simulator build only which aligns to expo/expo#14735.
gabrieldonadel
pushed a commit
to expo/react-native
that referenced
this pull request
Aug 12, 2025
RCTKeyCommands uses iOS private symbols to hook keyboard commands. originally it's debug build only, however, we enable `RCT_DEV` in Expo Go even on release build. this change updates the functionalities for simulator build only which aligns to expo/expo#14735.
gabrieldonadel
pushed a commit
to expo/react-native
that referenced
this pull request
Aug 15, 2025
RCTKeyCommands uses iOS private symbols to hook keyboard commands. originally it's debug build only, however, we enable `RCT_DEV` in Expo Go even on release build. this change updates the functionalities for simulator build only which aligns to expo/expo#14735.
gabrieldonadel
pushed a commit
to expo/react-native
that referenced
this pull request
Aug 27, 2025
RCTKeyCommands uses iOS private symbols to hook keyboard commands. originally it's debug build only, however, we enable `RCT_DEV` in Expo Go even on release build. this change updates the functionalities for simulator build only which aligns to expo/expo#14735.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We've had to revert updates to the reload command because they access private APIs that are rejected by App Store reviews, however we can still include these commands (perhaps more useful anyways) on simulator builds only.
How
Wrapped the code in question with the
TARGET_IPHONE_SIMULATORmacro so that it is stripped from production (archived) buildsTest Plan
Reload command should work on simulator builds by using the
rkey on your keyboard. This shouldn't be applied when a text input is focused. Should not appear in the Expo Go archived build, although I'm not quite sure how to go about verifying this (inspect with thestringscommand maybe?) @brentvatne your thoughts on this would be appreciatedChecklist
expo build(eg: updated@expo/xdl).expo prebuild& EAS Build (eg: updated a module plugin).