i18n Colorset translations #181

rogerfachini · 2014-11-19T02:38:58Z

This should translate the colorsets successfully. Currently only the generic-standard colorset has translation files, though.

@techninja

This is a proof of concept for #167 and #169, adds basic functionality for translation the names of colors in colorsets while still keeping them modular. @techninja and I talked about the main issues with this still, mainly including the namespaces in the colorset JSON file, and the general functionality (or lack thereof) of translations in modes.

@RI0

New translation file from @RI0

techninja · 2014-11-19T07:04:27Z

Awesome, thank you guys for your work so far. This is complicated and hasn't been done anywhere in the system yet, there's likely to be some confusion in how to make it all work, or the best path, so there's likely to be a bit of discussion here.

Colors as numbers in translation key:

I mentioned in some late night video call that I was on the fence about non-specific color names. One of the whole points of translation string keys is that they are a source language reference, like generic.colors.blue, not generic.colors.color0. Of course in that same light, you wouldn't have generic.info.type, you'd have generic.info.generic... not very nice or obvious.

In a way, the translation files themselves define the content, why have a definition file filled with known expected strings that will be mostly the same? It's silly. Perhaps what might be better: Have the translation strings in the files as expected, in their current format of color0-7, type, manufacturer, etc... But remove any reference from the colorset definition file. IN that way, all the translatable strings stay in their translation files, and non-translatable stuff like what media it's for and the color values (as an non-keyed array).

Then when you want to output the translations, you simply know what key to use as it's standardized. Simplifies the format, and clarifies the use.

If you want I can submit a PR to your branch here so you can get an idea of what I'm talking about.

rogerfachini · 2014-11-19T07:43:45Z

I think I get the idea enough to not require you to make a PR to the branch. I think removing the i18n strings from the definition file will make a lot more sense than the system I had implemented. These are the things that I plan to change in colorset translation (serves as a list for me to follow and let me know if there's anything I should change further) :
- Name, type, description defined in i18n file rather than the definition file.
- color0-colorN will reference the non-keyed array of color values (color0 -> 0th position in the array).
- Refactor key names for colorsets (generic.colors.color0 will be colorsets.generic.color0) to make it more readable. (generic.info.generic could become colorsets.info.generic to consolidate it as well.

techninja · 2014-11-19T16:51:12Z

Sounds good except: info.generic: "Generic" vs info.type: "Generic". That is to say this is about having the key be a version of the translated content vs a locked-in identifier. If we don't have anything referencing the translation key in "content" (the definition file), then we need to lock down the key so we can hard code the key, or at least most of it (less the prefix/context/namespace) :)

RI0 · 2014-11-23T20:19:48Z

Would it make sense to use the hex code as a key and then have
some sort of list that could be used in the colour sets?
000000, en-US, Black
000000, fr, Noir
000000, es, Negro

We should have all the English versions so any colour that does
not have a translation will be shown in English.

rogerfachini · 2014-11-23T21:56:18Z

We are planning on splitting up the data into two separate places: all the translation data will stay in the i18n files and the remaining data will be in the definiton file. The colors will be stored in a non-keyed array, like this:
"colors": [
"#000000",
"#FF0000",
"#FFA500",
"#FFFF00",
"#008000",
"#0000FF",
"#800080",
"#8B4513"
]

and the color definitions will look like this:

"color0": "Black",
"color1": "Red",
"color2": "Orange",
"color3": "Yellow",
"color4": "Green",
"color5": "Blue",
"color6": "Purple",
"color7": "Brown"

We plan on putting it so that color0 will be the name for the color in the 0th position of the non-keyed array.

@RI0

Just committing the data files so @RI0 can see the format.

rogerfachini · 2014-11-23T22:11:25Z

@RI0 you may want to have a look at these files in my branch:
https://github.com/rogerfachini/robopaint/blob/Colorsets-i18n/resources/colorsets/generic/generic.json
https://github.com/rogerfachini/robopaint/blob/Colorsets-i18n/resources/colorsets/generic/i18n/en-US.json
We changed the format up a bit, so if you want to translate into this format feel free, I only had time to do the generic set as a test.
The hex code as a key idea works in theory, but not so well in practice. The key is supposed to represent the data in as verbose a way as possible, so while the hex code does a good job at keeping things compact, "colorsets.generic.#8B4513" does not do as good of a job at describing the content it contains. Making translations default to a certain language if missing is a good idea, and is certainly possible, though makes it less obvious if the translation is missing or if the word just wasn't translated from English. Any thoughts @techninja ?

Adjust globe icon location for language select menu

After a VERY busy week of me not having time to work on robopaint, I finally got colorset translations DONE and WORKING (for the most part)! I was only able to port the colorsets over to English, but this gives our translation gurus a template to work off of. Anyways, here's a feature list: - Added i18n folders and en-US translation files for respective colorsets - Modified colorset definition files to move all text elements to i18n files. - Modified colorset parser to get text from i18n file and reference a non-keyed color array.

rogerfachini · 2014-11-27T18:24:43Z

Just got colorset translations to work! Before this is ready to be pulled, we need translations for colorsets for Spanish and French. If you switch languages in a colorset other than generic you get a FOVBBUC (Flash of Very Big Butt Ugly Content) due to a lack of translation file for that colorset!

techninja · 2014-11-30T00:30:39Z

Roger and I have discussed this in great detail over an hour or so and we should be in good shape to make this real very soon. Translations of color names will be easier, the format is simpler (mostly), and the general readability and output will be cleaned up.

@rogerfachini make sure to post screenshots in two languages when complete :)

@techninja

After some very through discussion with @techninja, we decided on this new format for colorsets that is more translation friendly. - Global colorsets i18n file for color and media names - definition files give the media, a machine name for referencing translatable text, and colors in a non-keyed array but with keyed colors for translation. - individual colorset i18n files give name, description, etc.

techninja · 2014-11-30T20:10:43Z

Great work so far, though I think you'll need to re-merge current master before I can get this in. Also you've got a bit more work to finish up the format of non-crayola files. Seems right on track for 0.9.5, but not for 0.9.2.

rogerfachini · 2014-11-30T21:15:11Z

Not quite sure I can find what I missed in the non-crayola files. Been looking through them and they seem to match. Working on the parsing code now, should be done fairly soon.

techninja · 2014-11-30T21:38:48Z

resources/colorsets/generic/i18n/es.json

+    "basetype": "colorset"
+  },
+  "info0": {
+    "media": "watercolor",


Should be no "media" here. Also the file name is wrong. Actually this whole file is wrong!

techninja · 2014-12-02T07:24:30Z

The size of the drop-down seems to have.. gone full width :P And it seems you've forgotten to remove the bold titles & media type output. Remember, no titles, just a bold manufacturer, a dash, the name (same line), then a newline space, and the description. That, or leave it and make sure the translation of the media type gets in there and we deal with the re-layout of this for the Eggbot stuff that will be completely redoing it...

techninja · 2014-12-02T07:27:22Z

resources/main.js

@@ -550,40 +552,48 @@ function getColorsets() {
      continue;
    }

-    // Move through all colorsets in file
+     // Move through all colorsets in file


You don't have to fix this, but look hard at every line in your commit diffs, it's easy to see little changes where you didn't intend that way.

@docprofsky

Thanks to @docprofsky 's translator (with a hotfix by me to get it to work), we now have preliminary translations for the other languages!

techninja · 2014-12-02T07:31:34Z

resources/main.js

-  // Report language switch to the console
-  console.info("Language Switched to: " + robopaint.settings.lang);
+  // Reload and reparse colorsets
+  getColorsets();


This is likely an unfortunate requirement. You either have to pull out string output from initial load, or you can reload the data over again. I suspect there's some efficiencies to be had in refactoring some of getColorSets(), but it's a very low volume function and as long as you've got it working, we're probably just fine :)

rogerfachini · 2014-12-02T07:33:43Z

Ok got the VERY fast translations in, there are some mistakes that we may have to catch later, but for now it works. Thank you for the present by the way. And just to clarify, the 🍰 is not a lie!

docprofsky · 2014-12-02T07:35:09Z

@rogerfachini Can you submit a PR with the fix? I tested it and it seemed to work fine (other than it changing the order of the JSON).

techninja · 2014-12-02T07:35:46Z

resources/colorsets/prang/i18n/prang.fr.json

+    "creator": "rogerfachini"
+  }, 
+  "metallic": {
+    "description": "Prang m\u00e9talliques Aquarelles 8 semi-humides, set 8 couleurs", 


For some reason, by default Python JSON output is ASCII safe, and therefore doesn't store the actual non-ascii unicode chars as the actual chars. Every part of our workflow should be Unicode safe, so I'd suggest seeing if you can't tweak the output as explained here.

rogerfachini · 2014-12-02T07:37:52Z

@docprofsky its not worth PR-ing: I just removed the command-line arguments (I wanted to run the script from my editor to make it easier) and made it easier to translate 10 or so different files in a row and get them into my repo.

rogerfachini · 2014-12-02T07:39:23Z

Oh and for comparison: here it is with the fixed files:

techninja · 2014-12-02T07:39:59Z

@rogerfachini Make sure the colorset dropdown doesn't randomly change width, that the JSON problems noted above are fixed, that the media type translates, and I'll merge it.

rogerfachini · 2014-12-02T07:46:55Z

The colorset dropdown is due to the largest item in it (In the broken translation picture this was due to the raw translation string being outputted, in the last picture the largest item was the french translation for 'add custom colorset', so that shouldn't be a problem). @docprofsky can fix the python side of the translation file issues but for now I will fix them manually. Should I just remove the media type from the list completely as it is unnecessary at this point (but can be re-added later)?

techninja · 2014-12-02T07:48:54Z

Translate it. Better to correct what's there than pull out too much before a big refactor.

techninja · 2014-12-02T07:49:34Z

And yea, make the JSON changes by hand, should be happy :)

Translate the media, too.

@docprofsky

Fixed all the glitches caused by @docprofsky 's very-much-in-beta translator!

rogerfachini · 2014-12-02T08:03:59Z

That should fix all the annoying glitches in the translate files.

techninja · 2014-12-02T08:18:35Z

resources/colorsets/i18n/colorsets.es.json

+    "yellow": "Amarillo", 
+    "yellowgreen": "Verde Amarillo", 
+    "redviolet": "Rojo Violeta", 
+    "orangered": "Orangered", 


😢 It appears "orangered" is not a translatable color. See if you can't cherry pick that to just be "orange red" before translation :P

techninja · 2014-12-02T08:22:21Z

REALLY close now! I can feel it. Fix the two little issues I've got there, upload a new screenshot and I'll merge this thing in!

rogerfachini · 2014-12-02T08:31:09Z

We shall miss you, Estrellarse (which apparently when translated back into English means 'crash'):

techninja · 2014-12-02T08:33:42Z

Ok, ok. No need to hold this thing back for anymore petty crap. It is good (enough)!

i18n Colorset translations

techninja · 2014-12-02T08:34:40Z

Let the race to get in the Chinese translations, begin! ;)

rogerfachini · 2014-12-02T08:36:13Z

And let the headaches ensue!

rogerfachini added 3 commits November 13, 2014 01:02

Colorsets now translate all subtext too

ddbc0e5

Add @RI0's French translation file

794cee4

New translation file from @RI0

File formats for color translations

f3ad544

Just committing the data files so @RI0 can see the format.

techninja added this to the 0.9.5 milestone Nov 24, 2014

techninja and others added 2 commits November 26, 2014 14:53

Merge pull request #183 from docprofsky/i18n_icon

611d576

Adjust globe icon location for language select menu

techninja mentioned this pull request Nov 30, 2014

PR: Add i18n translations to colorsets #169

Closed

rogerfachini added 8 commits November 29, 2014 23:20

Forgot to remove a file that was renamed

0e49c84

Updated Generic colorset to new format

5a6ad90

Updated all Prang colorsets to new format

9eb8271

Forgot to delete the old en-US

760aafa

Updated Sargent colorsets to new format

6d2370c

Remove deleted file

3d63b5c

"vermillion" is not a color!

df6bc7c

rogerfachini added 2 commits November 30, 2014 12:31

Newlines at end of files

024d585

Small format fix

3e94c35

techninja reviewed Nov 30, 2014
View reviewed changes

techninja reviewed Dec 2, 2014
View reviewed changes

Quick and Dirty translations for existing languages

46db96a

Thanks to @docprofsky 's translator (with a hotfix by me to get it to work), we now have preliminary translations for the other languages!

techninja reviewed Dec 2, 2014
View reviewed changes

rogerfachini added 2 commits December 1, 2014 23:54

Media now translates

36038ef

Translate the media, too.

Cleaned up translation files

74d38fe

Fixed all the glitches caused by @docprofsky 's very-much-in-beta translator!

techninja reviewed Dec 2, 2014
View reviewed changes

rogerfachini added 2 commits December 2, 2014 00:27

Removed the offending "Star-butt"

3038cb6

Changed 'orangered' to two words to translate

8f2ead3

techninja added a commit that referenced this pull request Dec 2, 2014

Merge pull request #181 from rogerfachini/Colorsets-i18n

2733c69

i18n Colorset translations

techninja merged commit 2733c69 into evil-mad:master Dec 2, 2014

rogerfachini deleted the Colorsets-i18n branch December 2, 2014 08:38

i18n Colorset translations #181

i18n Colorset translations #181

Uh oh!

Conversation

rogerfachini commented Nov 19, 2014

Uh oh!

techninja commented Nov 19, 2014

Colors as numbers in translation key:

Uh oh!

rogerfachini commented Nov 19, 2014

Uh oh!

techninja commented Nov 19, 2014

Uh oh!

RI0 commented Nov 23, 2014

Uh oh!

rogerfachini commented Nov 23, 2014

Uh oh!

rogerfachini commented Nov 23, 2014

Uh oh!

rogerfachini commented Nov 27, 2014

Uh oh!

techninja commented Nov 30, 2014

Uh oh!

techninja commented Nov 30, 2014

Uh oh!

rogerfachini commented Nov 30, 2014

Uh oh!

techninja Nov 30, 2014

Choose a reason for hiding this comment

Uh oh!

techninja commented Dec 2, 2014

Uh oh!

techninja Dec 2, 2014

Choose a reason for hiding this comment

Uh oh!

techninja Dec 2, 2014

Choose a reason for hiding this comment

Uh oh!

rogerfachini commented Dec 2, 2014

Uh oh!

docprofsky commented Dec 2, 2014

Uh oh!

techninja Dec 2, 2014

Choose a reason for hiding this comment

Uh oh!

rogerfachini commented Dec 2, 2014

Uh oh!

rogerfachini commented Dec 2, 2014

Uh oh!

techninja commented Dec 2, 2014

Uh oh!

rogerfachini commented Dec 2, 2014

Uh oh!

techninja commented Dec 2, 2014

Uh oh!

techninja commented Dec 2, 2014

Uh oh!

rogerfachini commented Dec 2, 2014

Uh oh!

techninja Dec 2, 2014

Choose a reason for hiding this comment

Uh oh!

techninja commented Dec 2, 2014

Uh oh!

rogerfachini commented Dec 2, 2014

Uh oh!

techninja commented Dec 2, 2014

Uh oh!

techninja commented Dec 2, 2014

Uh oh!

rogerfachini commented Dec 2, 2014

Uh oh!

Uh oh!