-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Update EIP-7883: Triple price #9969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ All reviewers have approved. |
| modexp_nagydani_4_pow0x10001 | 21845 | 131072 | 500% | | ||
| modexp_nagydani_5_square | 5461 | 32768 | 500% | | ||
| modexp_nagydani_5_qube | 5461 | 32768 | 500% | | ||
| modexp_nagydani_5_pow0x10001 | 87381 | 525288 | 500% | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We got 524288
for modexp_nagydani_5_pow0x10001
. It's the only discrepancy we have. Should this be the case? I am double checking now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have 524288
too, so it was a typo. I will fix it in a moment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
Update the [EIP-7883 "ModExp Gas Cost Increase"](https://eips.ethereum.org/EIPS/eip-7883) to the latest revision: - ethereum/EIPs#9855 - ethereum/EIPs#9969
Update the [EIP-7883 "ModExp Gas Cost Increase"](https://eips.ethereum.org/EIPS/eip-7883) to the latest revision: - ethereum/EIPs#9855 - ethereum/EIPs#9969
Tripling the price for ModExp calls.
Moving worst-performing ModExp test case from 18 to about 31MGas/s.