Skip to content

Conversation

CarlBeek
Copy link
Contributor

No description provided.

@CarlBeek CarlBeek requested a review from eth-bot as a code owner May 28, 2025 05:57
@github-actions github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-core labels May 28, 2025
@eth-bot
Copy link
Collaborator

eth-bot commented May 28, 2025

✅ All reviewers have approved.

@eth-bot eth-bot added e-consensus Waiting on editor consensus e-review Waiting on editor to review labels May 28, 2025
@eth-bot eth-bot changed the title Adds EIP for secp256r1 Add EIP: Precompile for secp256r1 Curve Support May 28, 2025
@github-actions github-actions bot added the w-ci Waiting on CI to pass label May 28, 2025
@CarlBeek
Copy link
Contributor Author

Self-assigned next EIP number: 7951

@benaadams
Copy link
Contributor

@benaadams
Copy link
Contributor

Ah see is improved spec on EIP-7212

lightclient
lightclient previously approved these changes May 28, 2025
@eth-bot eth-bot enabled auto-merge (squash) May 28, 2025 12:28
eth-bot
eth-bot previously approved these changes May 28, 2025
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

auto-merge was automatically disabled May 28, 2025 16:38

Head branch was pushed to by a user without write access

@CarlBeek CarlBeek dismissed stale reviews from eth-bot and lightclient via ad5d1b5 May 28, 2025 16:38
@github-actions github-actions bot added w-ci Waiting on CI to pass and removed w-ci Waiting on CI to pass labels May 28, 2025
@CarlBeek CarlBeek requested a review from lightclient May 31, 2025 18:07
@timbeiko
Copy link
Contributor

@g11tech can we merge this even if there are issues? We've got the EIP scheduled for devnets but it doesn't even formally exist yet 😅

@g11tech
Copy link
Contributor

g11tech commented Jun 30, 2025

@SamWilsn has the rights to force merge

g11tech
g11tech previously approved these changes Jun 30, 2025
@eth-bot eth-bot enabled auto-merge (squash) June 30, 2025 21:44
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

EIPS/eip-7951.md Outdated

## Test Cases

A set of test vectors for verifying implementations is located in a separate [file](../assets/eip-xxxx/test-vectors.json).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
A set of test vectors for verifying implementations is located in a separate [file](../assets/eip-xxxx/test-vectors.json).
A set of test vectors for verifying implementations is located in a separate [file](../assets/eip-7951/test-vectors.json).

@g11tech @timbeiko it seems very easy to fix

eth-bot
eth-bot previously approved these changes Jun 30, 2025
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@lightclient lightclient dismissed stale reviews from eth-bot and g11tech via 2b9e927 July 1, 2025 20:07
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Jul 1, 2025
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit d386b29 into ethereum:master Jul 1, 2025
11 of 12 checks passed
fjl added a commit to ethereum/go-ethereum that referenced this pull request Jul 7, 2025
ethereum/EIPs#9833

Based on #27540, #30043

---------

Co-authored-by: Ulaş Erdoğan <uerdogan2001@hotmail.com>
JonathanOppenheimer added a commit to ava-labs/libevm that referenced this pull request Aug 11, 2025
ethereum/EIPs#9833

Based on ethereum#27540, ethereum#30043

---------

Co-authored-by: Ulaş Erdoğan <uerdogan2001@hotmail.com>
JonathanOppenheimer added a commit to ava-labs/libevm that referenced this pull request Aug 12, 2025
ethereum/EIPs#9833

Based on ethereum#27540, ethereum#30043

---------

Co-authored-by: Ulaş Erdoğan <uerdogan2001@hotmail.com>
JonathanOppenheimer added a commit to ava-labs/libevm that referenced this pull request Aug 12, 2025
ethereum/EIPs#9833

Based on ethereum#27540, ethereum#30043

---------

Co-authored-by: Ulaş Erdoğan <uerdogan2001@hotmail.com>
JonathanOppenheimer added a commit to ava-labs/libevm that referenced this pull request Aug 12, 2025
ethereum/EIPs#9833

Based on ethereum#27540, ethereum#30043

---------

Co-authored-by: Ulaş Erdoğan <uerdogan2001@hotmail.com>
JonathanOppenheimer pushed a commit to ava-labs/libevm that referenced this pull request Aug 13, 2025
ethereum/EIPs#9833

Based on ethereum#27540, ethereum#30043

---------

Co-authored-by: Ulaş Erdoğan <uerdogan2001@hotmail.com>
JonathanOppenheimer pushed a commit to ava-labs/libevm that referenced this pull request Aug 13, 2025
ethereum/EIPs#9833

Based on ethereum#27540, ethereum#30043

---------

Co-authored-by: Ulaş Erdoğan <uerdogan2001@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-new Creates a brand new proposal e-consensus Waiting on editor consensus e-review Waiting on editor to review s-draft This EIP is a Draft t-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.