Update EIP-7685: change requests hash to flat hash #8854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to create a tree hash over the requests, since proofs related to requests will be made over the CL block. The EL block body stores unvalidated requests and will never be used for proofs. Removing the tree hash simplifies things.
|
🛑 Auto merge failed. Please see logs for more details, and report this issue at the |
|
This makes sense to me in general. We won't be seeing light client proofs against this data as it will be included natively in the CL. |
This was referenced Sep 4, 2024
|
Moreover, we have requests data in logs ethereum/sys-asm#17 |
25 tasks
lightclient
reviewed
Sep 26, 2024
lightclient
approved these changes
Sep 26, 2024
Scamreno
approved these changes
Sep 26, 2024
3 tasks
12 tasks
13 tasks
8 tasks
13 tasks
somnathb1
added a commit
to erigontech/erigon
that referenced
this pull request
Oct 23, 2024
Summary of changes - Remove `Requests` interface in favour of new `FlatRequest` struct - Add changes for new `RequestHash` calculation that `sha256` digests the set of flat requests - Remove `Requests` from block and body related structs and methods - Set of requests that gets pulled at the `Finalize` stage is now returned from there, both for execution and block-building Ref1: ethereum/execution-apis#591 Ref2: ethereum/EIPs#8854 Ref3: ethereum/EIPs#8924 Needs interface change - erigontech/interfaces#239 (Tasks board - #12106)
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to create a tree hash over the requests, since proofs related to requests will be made over the CL block. The EL block body stores unvalidated requests and will never be used for proofs. Removing the tree hash simplifies things.