Skip to content

Conversation

asanso
Copy link
Contributor

@asanso asanso commented Apr 24, 2024

ATTENTION: ERC-RELATED PULL REQUESTS NOW OCCUR IN ETHEREUM/ERCS

--

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@asanso asanso requested a review from eth-bot as a code owner April 24, 2024 11:23
@github-actions github-actions bot added c-update Modifies an existing proposal s-review This EIP is in Review t-core labels Apr 24, 2024
Copy link
Member

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! thanks for adding these

@eth-bot
Copy link
Collaborator

eth-bot commented Apr 24, 2024

✅ All reviewers have approved.

@eth-bot eth-bot changed the title Finalizing test vectors for EIP-2537 Update EIP-2537: Finalizing test vectors for EIP-2537 Apr 24, 2024
@eth-bot eth-bot enabled auto-merge (squash) April 24, 2024 15:45
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit 57638c1 into ethereum:master Apr 24, 2024
somnathb1 added a commit to erigontech/erigon that referenced this pull request May 16, 2024
See ethereum/EIPs#8456 &
ethereum/EIPs#8497.

I updated the tests from
https://github.com/ethereum/EIPs/tree/master/assets/eip-2537 and split
them into separate files from the previously existing tests.

---------

Co-authored-by: Somnath Banerjee <snb895@outlook.com>
yperbasis added a commit to erigontech/erigon that referenced this pull request Oct 1, 2024
See ethereum/EIPs#8456 &
ethereum/EIPs#8497.

I updated the tests from
https://github.com/ethereum/EIPs/tree/master/assets/eip-2537 and split
them into separate files from the previously existing tests.

---------

Co-authored-by: Somnath Banerjee <snb895@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-update Modifies an existing proposal s-review This EIP is in Review t-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants