In case of an ico file a height or with of 0 actually means 256 #592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewnoakes
reviewed
Nov 28, 2022
Comment on lines
37
to
38
| public class IcoReader | ||
| { | ||
| public void extract(@NotNull final SequentialReader reader, @NotNull final Metadata metadata) | ||
| { | ||
| public class IcoReader { | ||
| public void extract(@NotNull final SequentialReader reader, @NotNull final Metadata metadata) { |
There was a problem hiding this comment.
Please revert the formatting change.
There was a problem hiding this comment.
Sorry, my IDE does that. It is reverted now
drewnoakes
added a commit
to drewnoakes/metadata-extractor-dotnet
that referenced
this pull request
Dec 12, 2022
Ports drewnoakes/metadata-extractor#592 from Java to .NET.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the specs on https://docs.fileformat.com/image/ico/ a width/height of 0 means 256 for ico files.