Fix reading arrays of Float64 in TIFF files #548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Double64 should take 8 bytes, instead of 4. I found this bug when I tried to read tags from a geotiff.
|
Nice find! We have the same bug in the C# version too it seems: |
drewnoakes
added a commit
to drewnoakes/metadata-extractor-dotnet
that referenced
this pull request
Jul 30, 2021
drewnoakes
added a commit
to drewnoakes/metadata-extractor-images
that referenced
this pull request
Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Double64 should take 8 bytes, instead of 4.
I found this bug when I tried to read tags from a geotiff.
The original data was
7B 14 AE 47 E1 7A 84 3F ----- 0.01 index 0 - 7
7B 14 AE 47 E1 7A 84 3F ----- 0.01 index 8 - 15
00 00 00 00 00 00 00 00 ----- 0 index 16 - 23
but metadata-extractor read it like this:
7B 14 AE 47 E1 7A 84 3F ------- index 0 - 7
E1 7A 84 3F 7B 14 AE 47 ------- index 4 - 11 [should be 8 - 15]
7B 14 AE 47 E1 7A 84 3F ------- index 8 - 15 [should be 16 - 23]