Skip to content

Conversation

gaius-qi
Copy link
Member

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added this to the v2.4.0 milestone Jul 24, 2025
@gaius-qi gaius-qi self-assigned this Jul 24, 2025
@gaius-qi gaius-qi requested a review from a team as a code owner July 24, 2025 09:45
@gaius-qi gaius-qi added the enhancement New feature or request label Jul 24, 2025
Copy link

@Liam-Zhao Liam-Zhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins enabled auto-merge (squash) July 24, 2025 09:48
Copy link

codecov bot commented Jul 24, 2025

Codecov Report

Attention: Patch coverage is 1.21951% with 162 lines in your changes missing coverage. Please review.

Project coverage is 32.50%. Comparing base (41da9b7) to head (b1b196d).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
scheduler/job/job.go 0.00% 151 Missing ⚠️
manager/service/job.go 0.00% 9 Missing ⚠️
manager/job/preheat.go 50.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4233      +/-   ##
==========================================
- Coverage   32.53%   32.50%   -0.03%     
==========================================
  Files         350      350              
  Lines       41360    41382      +22     
==========================================
- Hits        13455    13452       -3     
- Misses      27014    27039      +25     
  Partials      891      891              
Flag Coverage Δ
unittests 32.50% <1.21%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
manager/job/preheat.go 43.18% <50.00%> (+0.04%) ⬆️
manager/service/job.go 0.00% <0.00%> (ø)
scheduler/job/job.go 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gaius-qi gaius-qi disabled auto-merge July 24, 2025 10:43
@gaius-qi gaius-qi merged commit 3bc50ee into main Jul 24, 2025
14 of 26 checks passed
@gaius-qi gaius-qi deleted the feature/preheat branch July 24, 2025 10:44
gaius-qi added a commit that referenced this pull request Jul 24, 2025
Signed-off-by: Gaius <gaius.qi@gmail.com>
gaius-qi added a commit that referenced this pull request Jul 24, 2025
Signed-off-by: Gaius <gaius.qi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants