feat: add the X-Dragonfly-Error-Type header to the response #1299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1299 +/- ##
==========================================
- Coverage 48.58% 48.55% -0.04%
==========================================
Files 60 60
Lines 15154 15196 +42
==========================================
+ Hits 7363 7378 +15
- Misses 7791 7818 +27
🚀 New features to boost your workflow:
|
681cb6a to
f8641c2
Compare
gaius-qi
requested changes
Aug 22, 2025
f8641c2 to
afc757a
Compare
afc757a to
f3c8a99
Compare
f3c8a99 to
524c871
Compare
Signed-off-by: chlins <chlins.zhang@gmail.com>
524c871 to
e9a40fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enhances error handling and reporting throughout the
dragonfly-clientproject, focusing on more explicit error typing and improved communication of error sources to clients via HTTP response headers. The main changes include introducing a new error type system, updating error responses to include error source information, and refactoring code to utilize these new mechanisms.Error Type System and Header Reporting:
Added a new
ErrorTypeenum indragonfly-client/src/proxy/header.rsto represent the source of errors (Backend,Proxy,Dfdaemon), along with a corresponding HTTP headerX-Dragonfly-Error-Typefor error responses. This helps clients identify where an error originated.Refactored the
make_error_responsefunction indragonfly-client/src/proxy/mod.rsto require anErrorTypeargument and to set the error type header in all error responses. All error response creation sites throughout the proxy code were updated to use this new function signature and provide the appropriate error type. [1] [2]Proxy Error Handling Improvements:
Updated proxy handler functions (
http_handler,https_handler,upgraded_handler, andproxy_via_http) to use the new error type system when returning error responses, ensuring clients can distinguish between proxy, backend, and dfdaemon errors. [1] [2] [3] [4]Enhanced error reporting in
proxy_via_dfdaemonto set the correct error type in all error response paths, including backend failures, dfdaemon failures, and general errors, improving traceability for clients. [1] [2] [3] [4] [5] [6] [7] [8] [9]Backend Error Propagation:
dragonfly-client-backend/src/http.rs) to return structured error responses with explicit success flags and error messages, rather than propagating errors viainspect_err. This makes error handling more robust and consistent. [1] [2] [3]Resource Task Error Handling:
Taskimplementation indragonfly-client/src/resource/task.rsto use the new error response structure, passing through optional status code and header fields directly, improving error information fidelity.Description
Related Issue
Motivation and Context
Screenshots (if appropriate)