Cap project tools to netcoreapp2.2 and block creating new package #3057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 27, 2019 16:44
Max project tools TFM will be netcoreapp2.2
wli3
commented
Mar 28, 2019
| @@ -38,8 +38,8 @@ Copyright (c) .NET Foundation. All rights reserved. | |||
| </PropertyGroup> | |||
|
|
|||
| <PropertyGroup Condition="'$(DotnetCliToolTargetFramework)' == '' And '$(BundledNETCoreAppTargetFrameworkVersion)' != ''"> | |||
| <!-- Set the TFM used to restore .NET CLI tools to match the version of .NET Core bundled in the CLI --> | |||
| <DotnetCliToolTargetFramework>netcoreapp$(BundledNETCoreAppTargetFrameworkVersion)</DotnetCliToolTargetFramework> | |||
| <!-- To move away from project tools. The highest available project tools TFM is netcoreapp2.2 --> | |||
There was a problem hiding this comment.
The full spec is not available to public yet
There was a problem hiding this comment.
I would say this:
Maximum supported target framework for DotnetCliProjectTools is .NET Core 2.2
|
pending remove --fx-version when run, but that change should be in CLI repo |
dsplaisted
approved these changes
Mar 28, 2019
| @@ -38,8 +38,8 @@ Copyright (c) .NET Foundation. All rights reserved. | |||
| </PropertyGroup> | |||
|
|
|||
| <PropertyGroup Condition="'$(DotnetCliToolTargetFramework)' == '' And '$(BundledNETCoreAppTargetFrameworkVersion)' != ''"> | |||
| <!-- Set the TFM used to restore .NET CLI tools to match the version of .NET Core bundled in the CLI --> | |||
| <DotnetCliToolTargetFramework>netcoreapp$(BundledNETCoreAppTargetFrameworkVersion)</DotnetCliToolTargetFramework> | |||
| <!-- To move away from project tools. The highest available project tools TFM is netcoreapp2.2 --> | |||
There was a problem hiding this comment.
I would say this:
Maximum supported target framework for DotnetCliProjectTools is .NET Core 2.2
src/Tests/Microsoft.NET.Pack.Tests/GivenThatWeWantToPackAProjectTool.cs
Outdated
Show resolved
Hide resolved
src/Tests/Microsoft.NET.Pack.Tests/GivenThatWeWantToPackAProjectTool.cs
Outdated
Show resolved
Hide resolved
src/Tests/Microsoft.NET.Pack.Tests/GivenThatWeWantToPackAProjectTool.cs
Outdated
Show resolved
Hide resolved
...osoft.NET.Restore.Tests/GivenThatWeWantToRestoreAndGenerateDepsjsonDotNetCliToolReference.cs
Outdated
Show resolved
Hide resolved
wli3
commented
Mar 28, 2019
| } | ||
|
|
||
| [Fact] | ||
| public void It_can_restore_with_netcoreapp2_2() |
There was a problem hiding this comment.
@dsplaisted I find the previous test restoring aspnet scaffolding is too slow, download too much, and may cause fullframework leg's time out. So I changed it to restore a sample project tool and only asset restore's TFM
This was referenced Apr 11, 2019
wli3
pushed a commit
that referenced
this pull request
Feb 7, 2020
….5 (#3057) - Microsoft.DotNet.Cli.Runtime - 5.0.100-alpha1.19503.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 work are separate commits