Skip to content

Coreclr compatibility: changed close to dispose & changed of scoping with using #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 16, 2015
Merged

Coreclr compatibility: changed close to dispose & changed of scoping with using #609

merged 2 commits into from
Jul 16, 2015

Conversation

grahamehorner
Copy link
Contributor

work on replacing .close() with .dispose() for coreclr port.

@dnfclas
Copy link

dnfclas commented Jul 15, 2015

Hi @grahamehorner, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

@dnfclas
Copy link

dnfclas commented Jul 15, 2015

@grahamehorner, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, DNFBOT;

@gabikliot
Copy link
Contributor

@grahamehorner , there is a compile time error: http://dotnet-ci.cloudapp.net/job/dotnet_orleans_prtest/699/consoleFull#-1294877310a82fefab-f698-416f-8fca-58544c94cd4e
7>Configuration\ClientConfiguration.cs(329,17): error CS0815: Cannot assign to an implicitly-typed local variable [d:\j\workspace\dotnet_orleans_prtest\src\Orleans\Orleans.csproj]

@gabikliot gabikliot added this to the CoreCLR milestone Jul 16, 2015
gabikliot added a commit that referenced this pull request Jul 16, 2015
@gabikliot
Merge pull request #609 from grahamehorner/coreclr-close-dispose
9da9a36 
changed close to dispose & changed of scoping with using
@gabikliot gabikliot merged commit 9da9a36 into dotnet:master Jul 16, 2015
@grahamehorner grahamehorner deleted the coreclr-close-dispose branch July 16, 2015 18:39
@gabikliot gabikliot changed the title changed close to dispose & changed of scoping with using Coreclr compatibility: changed close to dispose & changed of scoping with using Jul 22, 2015
@jdom jdom mentioned this pull request Aug 9, 2016
Merged
@gabikliot gabikliot mentioned this pull request Aug 9, 2016
Closed
30 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Dec 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
CoreCLR
Development

Successfully merging this pull request may close these issues.
4 participants
@grahamehorner @dnfclas @gabikliot @jthelin