Skip to content

Refine handling of moving between replay and continue states #3337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 26, 2025
Merged

Refine handling of moving between replay and continue states #3337

merged 3 commits into from
May 26, 2025

Conversation

Wraith2
Copy link
Contributor

@Wraith2 Wraith2 commented May 7, 2025

fixes #3336

Refines moving between ReplayRunning and ContinueRunning states fixing an issue with varbinary reads.

@cheenamalhotra
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@cheenamalhotra cheenamalhotra added this to the 6.1-preview2 milestone May 7, 2025
@codecov Codecov
Copy link

codecov bot commented May 8, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 59.45946% with 15 lines in your changes missing coverage. Please review.

Project coverage is 59.54%. Comparing base (b8948f2) to head (6485691).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
.../netcore/src/Microsoft/Data/SqlClient/TdsParser.cs 0.00% 5 Missing ⚠️
...nt/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs 0.00% 5 Missing ⚠️
...c/Microsoft/Data/SqlClient/TdsParserStateObject.cs 78.26% 5 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (b8948f2) and HEAD (6485691). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (b8948f2) HEAD (6485691)
addons 1 0
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3337      +/-   ##
==========================================
- Coverage   67.04%   59.54%   -7.51%     
==========================================
  Files         300      293       -7     
  Lines       65376    65077     -299     
==========================================
- Hits        43831    38749    -5082     
- Misses      21545    26328    +4783
Flag Coverage Δ
addons ?
netcore 62.85% <68.75%> (-9.34%) ⬇️
netfx 60.79% <68.75%> (-4.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Wraith2
Copy link
Contributor Author

Wraith2 commented May 9, 2025

The CI failures are caused by nuget timeouts.
I'll need this merged to build on it and fix #3331

This was referenced May 11, 2025
Closed
Closed
@Wraith2 Wraith2 requested a review from a team as a code owner May 20, 2025 19:35
@Wraith2
Copy link
Contributor Author

Wraith2 commented May 20, 2025

Can I get CI and review on this please? There are further fixes waiting that build on this one.

@mdaigle
Copy link
Contributor

mdaigle commented May 20, 2025

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@Wraith2
Copy link
Contributor Author

Wraith2 commented May 20, 2025

I'm not sure if the CI is having problems or there is a real issue with the code.

@mdaigle
Copy link
Contributor

mdaigle commented May 21, 2025

It looks like one job timed out, but everything else succeeded. I kicked that one job.

mdaigle
mdaigle requested changes May 21, 2025
View reviewed changes
@Wraith2
Copy link
Contributor Author

Wraith2 commented May 21, 2025

When I looked (and subsequently commented) the CI had been running for 3 hours without either timing our or completing so i was concerned that I'd introduced a hanging behaviour. If it managed to complete then I haven't

Can you start the CI please.

@mdaigle
Copy link
Contributor

mdaigle commented May 21, 2025

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

paulmedynski
paulmedynski requested changes May 22, 2025
View reviewed changes
Copy link
Contributor

@paulmedynski paulmedynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments.

@paulmedynski
Copy link
Contributor

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@cheenamalhotra cheenamalhotra merged commit 265f522 into dotnet:main May 26, 2025
237 checks passed
@Wraith2 Wraith2 deleted the fix-3336 branch May 26, 2025 19:56
This was referenced May 27, 2025
Merged
Closed
samsharma2700 added a commit that referenced this pull request Aug 5, 2025
@samsharma2700
Revert "Refine handling of moving between replay and continue states (#…
a2863dd 
…3337)"

This reverts commit 265f522.
mdaigle added a commit that referenced this pull request Aug 6, 2025
@mdaigle
Revert "Refine handling of moving between replay and continue states (#…
37db170 
…3337)"

This reverts commit 265f522.
cheenamalhotra added a commit that referenced this pull request Aug 14, 2025
@mdaigle @cheenamalhotra
[6.1] Revert partial packet fixup and replay improvements (#3556)
eb7a9da 
* Revert 1af7327

* Revert "Fix TryReadPlpBytes throws ArgumentException (#3470) (#3474)"

This reverts commit 0a55896.

* Revert 44762d9

* Revert "Improve async string perf and fix reading chars with initial offset. (#3377)"

This reverts commit 05df554.

* Revert "Refine handling of moving between replay and continue states (#3337)"

This reverts commit 265f522.

* Revert "Fix SqlCached buffer async read with continue edge case. (#3329)"

This reverts commit c3857b1.

* Revert "Add `async` snapshot continue capability for multipacket fields (#3161)"

This reverts commit 33364e7.

* Revert "Add partial packet detection and fixup (#2714)"

This reverts commit 8d5e4f2.

* Remove methods previously moved to common file.

* Supply byte buffer to vector read.

* Minor compilation fixes that were missed in the reverts.

* Remove partial packet context switch helpers.

* Remove accidental duplication of SqlDataReader

* Revert len change

* Undo buff rental in netfx to simplify 6.0 diff.

* Fix missed rented buff code.

---------

Co-authored-by: Cheena Malhotra <cmalhotra@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulmedynski paulmedynski paulmedynski approved these changes

@mdaigle mdaigle mdaigle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.1-preview2
Development

Successfully merging this pull request may close these issues.

6.1 Preview 1 Bug reading VARBINARY
4 participants
@Wraith2 @cheenamalhotra @mdaigle @paulmedynski