Skip to content

Feature Extension Changes for Vector Datatype Support #3209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Apr 16, 2025
Merged

Feature Extension Changes for Vector Datatype Support #3209

merged 12 commits into from
Apr 16, 2025

Conversation

apoorvdeshmukh
Copy link
Contributor

This PR adds feature extension support for vector datatype that allows MDS to fetch vector data in native binary format in which it is stored at the server.

@apoorvdeshmukh apoorvdeshmukh requested a review from a team March 11, 2025 16:11
@Wraith2
Copy link
Contributor

Wraith2 commented Mar 11, 2025

What is the format of vector data? what does it look like and what type would you expect GetFieldValue to return for it?

@apoorvdeshmukh
Copy link
Contributor Author

What is the format of vector data? what does it look like and what type would you expect GetFieldValue to return for it?

@Wraith2 We are still in the process of updating the TDS document with the relevant details for vector data. These changes are meant for the feature branch, and we plan to update the TDS document and finalize the SqlClient APIs before we start preparing changes for the main. Will share the details soon.

paulmedynski
paulmedynski requested changes Mar 14, 2025
View reviewed changes
Copy link
Contributor

@paulmedynski paulmedynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some copy/paste issues to fix :) And a few other comments.

paulmedynski
paulmedynski requested changes Mar 19, 2025
View reviewed changes
Copy link
Contributor

@paulmedynski paulmedynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need some tests that the feature negotiation works as expected.

@paulmedynski paulmedynski self-assigned this Mar 21, 2025
@paulmedynski paulmedynski added this to the 6.1-preview2 milestone Apr 2, 2025
@mdaigle mdaigle self-assigned this Apr 2, 2025
@cheenamalhotra cheenamalhotra removed this from the 6.1-preview2 milestone Apr 10, 2025
@cheenamalhotra
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dotnet dotnet deleted a comment from azure-pipelines bot Apr 11, 2025
@apoorvdeshmukh
Copy link
Contributor Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov Codecov
Copy link

codecov bot commented Apr 11, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.88889% with 4 lines in your changes missing coverage. Please review.

Project coverage is 66.28%. Comparing base (61e2317) to head (0225ce5).
Report is 7 commits behind head on feat/vectorSupport.

Files with missing lines Patch % Lines
...crosoft/Data/SqlClient/SqlInternalConnectionTds.cs 81.81% 2 Missing ⚠️
...crosoft/Data/SqlClient/SqlInternalConnectionTds.cs 81.81% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (61e2317) and HEAD (0225ce5). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (61e2317) HEAD (0225ce5)
addons 1 0
Additional details and impacted files 
@@                  Coverage Diff                   @@
##           feat/vectorSupport    #3209      +/-   ##
======================================================
- Coverage               72.81%   66.28%   -6.54%     
======================================================
  Files                     297      291       -6     
  Lines                   59661    59387     -274     
======================================================
- Hits                    43440    39362    -4078     
- Misses                  16221    20025    +3804
Flag Coverage Δ
addons ?
netcore 69.01% <88.88%> (-6.18%) ⬇️
netfx 65.21% <88.88%> (-6.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

paulmedynski
paulmedynski requested changes Apr 14, 2025
View reviewed changes
Copy link
Contributor

@paulmedynski paulmedynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're still missing some tests for combinations of server support and version negotiation.

paulmedynski
paulmedynski requested changes Apr 16, 2025
View reviewed changes
Copy link
Contributor

@paulmedynski paulmedynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some thoughts about if/when to fail a connection due to bad vector FE tokens, and other test robustness suggestions.

@apoorvdeshmukh apoorvdeshmukh merged commit 4e48ced into dotnet:feat/vectorSupport Apr 16, 2025
122 checks passed
apoorvdeshmukh added a commit that referenced this pull request May 26, 2025
@apoorvdeshmukh
Feature Extension Changes for Vector Datatype Support (#3209)
3a78e03 
This commit adds feature extension for vector datatype support.
Additionally, GenericTDSServer has been enhanced to enable tests
to validate login requests and response for the vector feature extension.
Tests have been added under SqlConnectionBasicTests through
TestConnWithVectorFeatExtVersionNegotiation.
apoorvdeshmukh added a commit that referenced this pull request May 26, 2025
@apoorvdeshmukh
Feature Extension Changes for Vector Datatype Support (#3209)
42ba741 
This commit adds feature extension for vector datatype support.
Additionally, GenericTDSServer has been enhanced to enable tests
to validate login requests and response for the vector feature extension.
Tests have been added under SqlConnectionBasicTests through
TestConnWithVectorFeatExtVersionNegotiation.
apoorvdeshmukh added a commit that referenced this pull request May 26, 2025
@apoorvdeshmukh
Feature Extension Changes for Vector Datatype Support (#3209)
b925db1 
This commit adds feature extension for vector datatype support.
Additionally, GenericTDSServer has been enhanced to enable tests
to validate login requests and response for the vector feature extension.
Tests have been added under SqlConnectionBasicTests through
TestConnWithVectorFeatExtVersionNegotiation.
apoorvdeshmukh added a commit that referenced this pull request Jun 3, 2025
@apoorvdeshmukh
Feature Extension Changes for Vector Datatype Support (#3209)
19f297c 
This commit adds feature extension for vector datatype support.
Additionally, GenericTDSServer has been enhanced to enable tests
to validate login requests and response for the vector feature extension.
Tests have been added under SqlConnectionBasicTests through
TestConnWithVectorFeatExtVersionNegotiation.
apoorvdeshmukh added a commit that referenced this pull request Jun 4, 2025
@apoorvdeshmukh
Feature Extension Changes for Vector Datatype Support (#3209)
4326f9c 
This commit adds feature extension for vector datatype support.
Additionally, GenericTDSServer has been enhanced to enable tests
to validate login requests and response for the vector feature extension.
Tests have been added under SqlConnectionBasicTests through
TestConnWithVectorFeatExtVersionNegotiation.
apoorvdeshmukh added a commit that referenced this pull request Jun 10, 2025
@apoorvdeshmukh
Feature Extension Changes for Vector Datatype Support (#3209)
5bd06fe 
This commit adds feature extension for vector datatype support.
Additionally, GenericTDSServer has been enhanced to enable tests
to validate login requests and response for the vector feature extension.
Tests have been added under SqlConnectionBasicTests through
TestConnWithVectorFeatExtVersionNegotiation.
apoorvdeshmukh added a commit that referenced this pull request Jun 10, 2025
@apoorvdeshmukh
Feature Extension Changes for Vector Datatype Support (#3209)
0015e13 
This commit adds feature extension for vector datatype support.
Additionally, GenericTDSServer has been enhanced to enable tests
to validate login requests and response for the vector feature extension.
Tests have been added under SqlConnectionBasicTests through
TestConnWithVectorFeatExtVersionNegotiation.
apoorvdeshmukh added a commit that referenced this pull request Jun 10, 2025
@apoorvdeshmukh
Feature Extension Changes for Vector Datatype Support (#3209)
7694aa8 
This commit adds feature extension for vector datatype support.
Additionally, GenericTDSServer has been enhanced to enable tests
to validate login requests and response for the vector feature extension.
Tests have been added under SqlConnectionBasicTests through
TestConnWithVectorFeatExtVersionNegotiation.
apoorvdeshmukh added a commit that referenced this pull request Jun 17, 2025
@apoorvdeshmukh
Feature Extension Changes for Vector Datatype Support (#3209)
2818ae5 
This commit adds feature extension for vector datatype support.
Additionally, GenericTDSServer has been enhanced to enable tests
to validate login requests and response for the vector feature extension.
Tests have been added under SqlConnectionBasicTests through
TestConnWithVectorFeatExtVersionNegotiation.
apoorvdeshmukh added a commit that referenced this pull request Jun 18, 2025
@apoorvdeshmukh
Feature Extension Changes for Vector Datatype Support (#3209)
fd912eb 
This commit adds feature extension for vector datatype support.
Additionally, GenericTDSServer has been enhanced to enable tests
to validate login requests and response for the vector feature extension.
Tests have been added under SqlConnectionBasicTests through
TestConnWithVectorFeatExtVersionNegotiation.
apoorvdeshmukh added a commit that referenced this pull request Jun 19, 2025
@apoorvdeshmukh
Feature Extension Changes for Vector Datatype Support (#3209)
811f433 
This commit adds feature extension for vector datatype support.
Additionally, GenericTDSServer has been enhanced to enable tests
to validate login requests and response for the vector feature extension.
Tests have been added under SqlConnectionBasicTests through
TestConnWithVectorFeatExtVersionNegotiation.
apoorvdeshmukh added a commit that referenced this pull request Jun 25, 2025
@apoorvdeshmukh
Feature Extension Changes for Vector Datatype Support (#3209)
c576041 
This commit adds feature extension for vector datatype support.
Additionally, GenericTDSServer has been enhanced to enable tests
to validate login requests and response for the vector feature extension.
Tests have been added under SqlConnectionBasicTests through
TestConnWithVectorFeatExtVersionNegotiation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@David-Engel David-Engel David-Engel left review comments

@cheenamalhotra cheenamalhotra cheenamalhotra approved these changes

@paulmedynski paulmedynski paulmedynski approved these changes

+1 more reviewer

@Wraith2 Wraith2 Wraith2 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@mdaigle mdaigle

@paulmedynski paulmedynski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@apoorvdeshmukh @Wraith2 @cheenamalhotra @David-Engel @paulmedynski @mdaigle