Skip to content

Fix ref assemblies for GetSqlJson #3154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 19, 2025
Merged

Fix ref assemblies for GetSqlJson #3154

merged 2 commits into from
Feb 19, 2025

Conversation

apoorvdeshmukh
Copy link
Contributor

@apoorvdeshmukh apoorvdeshmukh commented Feb 12, 2025 •
edited
Loading

Fixes #3135

paulmedynski
paulmedynski requested changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@paulmedynski paulmedynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

@paulmedynski paulmedynski added this to the 6.0.2 milestone Feb 13, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 19, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.15%. Comparing base (17cb0b0) to head (0b0df19).
Report is 6 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (17cb0b0) and HEAD (0b0df19). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (17cb0b0) HEAD (0b0df19)
addons 1 0
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3154      +/-   ##
==========================================
- Coverage   72.96%   66.15%   -6.82%     
==========================================
  Files         283      279       -4     
  Lines       58997    58945      -52     
==========================================
- Hits        43048    38993    -4055     
- Misses      15949    19952    +4003
Flag Coverage Δ
addons ?
netcore 69.17% <ø> (-6.56%) ⬇️
netfx 64.87% <ø> (-6.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apoorvdeshmukh apoorvdeshmukh merged commit 6151075 into dotnet:main Feb 19, 2025
123 checks passed
apoorvdeshmukh added a commit to apoorvdeshmukh/SqlClient that referenced this pull request Feb 19, 2025
@apoorvdeshmukh
Fix ref assemblies for GetSqlJson (dotnet#3154)
be3bc23
@apoorvdeshmukh apoorvdeshmukh mentioned this pull request Feb 19, 2025
Closed
@mdaigle mdaigle modified the milestones: 6.0.2, 7.0-preview1 Feb 19, 2025
apoorvdeshmukh added a commit that referenced this pull request Feb 20, 2025
@apoorvdeshmukh
Fix ref assemblies for GetSqlJson (#3154)
aaac29a
@apoorvdeshmukh apoorvdeshmukh mentioned this pull request Feb 20, 2025
Merged
apoorvdeshmukh added a commit that referenced this pull request Feb 20, 2025
@apoorvdeshmukh
Fix ref assemblies for GetSqlJson (#3154) (#3169)
dafc5a5
@apoorvdeshmukh apoorvdeshmukh added the Area\Json Use this for issues that are targeted for the Json feature in the driver. label Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saurabh500 saurabh500 saurabh500 approved these changes

@paulmedynski paulmedynski paulmedynski approved these changes

@benrr101 benrr101 Awaiting requested review from benrr101

@mdaigle mdaigle Awaiting requested review from mdaigle

@cheenamalhotra cheenamalhotra Awaiting requested review from cheenamalhotra

@samsharma2700 samsharma2700 Awaiting requested review from samsharma2700

@VladimirReshetnikov VladimirReshetnikov Awaiting requested review from VladimirReshetnikov

Assignees
No one assigned
Labels
Area\Json Use this for issues that are targeted for the Json feature in the driver.
Projects
None yet
Milestone
6.1-preview1
Development

Successfully merging this pull request may close these issues.

GetSqlJson method missing from refs assembly
4 participants
@apoorvdeshmukh @saurabh500 @paulmedynski @mdaigle