forked from MycroftAI/mycroft-core
-
Notifications
You must be signed in to change notification settings - Fork 0
update #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
update #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes duplicated code and makes method easier to test
- Tests for TTS base class - Test for TTS playback queue - Test for TTS Factory create - Tests for Mimic2 TTS - Tests for Mimic TTS - Tests for Google TTS
Add TTS tests
Disable failing spanish datetime test
This makes it possible for the installer skill to report errors during install and remove of skills
Update msm to 0.8.5
This is more inline with the tests that are performed in the file. This also adds a test for stop_speaking
This includes init, shutdown, play, stop, next, previous, pause, seek_backward, seek_forward, queue lower_volume, restore_volume and resume.
Add tests for the audioservice interface
Add readthedocs docs for settings_change_callback
The message is sent when there are no more tracks in the queue and playback has stopped.
Send mycroft.audio.queue_end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(Description of what the PR does, such as fixes # {issue number})
How to test
(Description of how to validate or test this PR)
Contributor license agreement signed?
CLA [ ] (Whether you have signed a CLA - Contributor Licensing Agreement