Skip to content
This repository was archived by the owner on Sep 8, 2024. It is now read-only.

Add TTS tests #2450

Merged
merged 5 commits into from
Jan 13, 2020
Merged

Add TTS tests #2450

merged 5 commits into from
Jan 13, 2020

Conversation

forslund
Copy link
Collaborator

Description

  • Add tests to the base class of the tts, Mimic, Mimic2 and Google.
  • Moves code away from mycroft/tts/__init__.py
  • Fixes issue with Mimic2 sentence preprocessing.

How to test

Make sure mimic1, mimic2 and google still works and that the Travis tests passes.

Contributor license agreement signed?

CLA [ Yes ]

@devs-mycroft devs-mycroft added the CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) label Jan 10, 2020
@forslund
Make Factory get Mimic TTS class from normal list
391b92c 
Removes duplicated code and makes method easier to test
@forslund
Add more TTS tests
eb3250f 
- Tests for TTS base class
- Test for TTS playback queue
- Test for TTS Factory create
- Tests for Mimic2 TTS
- Tests for Mimic TTS
- Tests for Google TTS
@forslund
Fix mimic2 text preprocessing
93ff3d7
@forslund
Clean-up
8f68222 
tts.py:
- remove unused import
-remove unused variable
- init TTS thread enclosure member
mimic2_tts.py: Fix docstrings
mimic_tts: Fix docstrings and remove unused variables and imports
google_tts: Improve docstrings
chrisveilleux
chrisveilleux approved these changes Jan 10, 2020
View reviewed changes
Copy link
Member

@chrisveilleux chrisveilleux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice bit of refactoring and testing. Thanks for doing this.

@forslund
Copy link
Collaborator Author

$(DEITY_OF_CHOICE) knows it's long overdue.

@forslund forslund merged commit 80b3ffb into MycroftAI:dev Jan 13, 2020
@forslund forslund deleted the refactor/tts branch January 13, 2020 14:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@krisgesling krisgesling Awaiting requested review from krisgesling

1 more reviewer

@chrisveilleux chrisveilleux chrisveilleux approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@forslund @chrisveilleux @devs-mycroft