build: raise maximum size limit for dockerfile and fix size check #2716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonistiigi
reviewed
Oct 3, 2024
Raise the maximum size limit for the dockerfile and correct the size check. The size check was intended to use the size attribute from the file stat, but the original gogo version confused the `Size()` method (which returned the size of the proto message) with the `Size` attribute (which was named `Size_`). During the conversion, we noticed the mistake but kept the incorrect behavior for the sake of keeping the conversion simple. This also raises the maximum limit because 512 kB is likely a bit too conservative. The limit has been raised to 2 MB and the limit has been included in the error message. Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com>
c8b8ad2 to
d7de22c
Compare
tonistiigi
approved these changes
Oct 3, 2024
jsternberg
added a commit
to jsternberg/buildx
that referenced
this pull request
Oct 4, 2024
Similar to docker#2716. Use the file size rather than the proto size, raise the allowed limit to the same value for consistency, and improve the error message to include the limit in human units. Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raise the maximum size limit for the dockerfile and correct the size check. The size check was intended to use the size attribute from the file stat, but the original gogo version confused the
Size()method (which returned the size of the proto message) with theSizeattribute (which was namedSize_).During the conversion, we noticed the mistake but kept the incorrect behavior for the sake of keeping the conversion simple.
This also raises the maximum limit because 512 kB is likely a bit too conservative. The limit has been raised to 2 MB and the limit has been included in the error message.