digestset: deprecate package in favor of go-digest/digestset #3775
Conversation
Codecov ReportBase: 57.06% // Head: 56.54% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #3775 +/- ##
==========================================
- Coverage 57.06% 56.54% -0.52%
==========================================
Files 105 104 -1
Lines 10806 10642 -164
==========================================
- Hits 6166 6018 -148
+ Misses 3952 3943 -9
+ Partials 688 681 -7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Opened cncf/cncf-fuzzing#236 as well to remove fuzzing for this package |
c0a39f3 to
ec7531a
Compare
ec7531a to
10cc230
Compare
|
@milosgajdos @corhere PTAL |
digestset/deprecated.go
Outdated
| var ErrDigestAmbiguous = digestset.ErrDigestAmbiguous | ||
|
|
||
| // Set is used to hold a unique set of digests which | ||
| // may be easily referenced by easily referenced by a string |
There was a problem hiding this comment.
| // may be easily referenced by easily referenced by a string | |
| // may be easily referenced by a string |
There was a problem hiding this comment.
Do you want to address this one @thaJeztah? This conversation was marked resolved without changing the code comment.
There was a problem hiding this comment.
oh! overlooked it; mistook it for changing the documentation links; fixing now
There was a problem hiding this comment.
updated; now it's done for real 😂
There was a problem hiding this comment.
LGTM but before you merge look into @corhere suggestions -- mind you if you accept the commits they won't add your signature and DCO will fail, so you wanna modify the code directly @thaJeztah
10cc230 to
afcbe02
Compare
Thx for the reminder; yes the suggestions are mixed blessing; nice way to show "this is what I suggest", but horrible that they screw up your commits 😂 Either way; updated; this one should be ready to go 👍 |
|
Whoop, still green; @corhere ptal 👍 |
This package was only used for the deprecated "shortid" syntax. Now that support for this syntax was removed, we can also remove this package. This patch deprecates and removes the package, adding temporary aliases pointing to the new location to ease migration from docker/distribution to the new distribution/distribution/v3. We should remove those aliases in a future update. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
afcbe02 to
7b651a9
Compare
Yeah, wanted to keep it close to the original for now (the aliases should also be temporarily 🤞) |
This package was only used for the deprecated "shortid" syntax. Now that
support for this syntax was removed, we can also remove this package.
This patch deprecates and removes the package, adding temporary aliases pointing
to the new location to ease migration from docker/distribution to the new
distribution/distribution/v3. We should remove those aliases in a future update.
With these changes, the docs look like below: