reference: remove support for deprecated "shortid" refs #3774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "shortid" syntax was added in moby/moby@d26a3b3, and allowed for matching an image on its ID prefix (this is before images were content-addressable). With the introduction of content-addressable references, this syntax became problematic, and Docker deprecated this syntax in 2016 (Docker v1.13.0) through commit; moby/moby@5fc7159 > The `repository:shortid` syntax for referencing images is very little used, > collides with tag references, and can be confused with digest references. Support for this syntax was removed in 2017 (Docker 17.12) through commit: moby/moby@a942c92 containerd uses a fork of the reference package with this syntax removed, and does not support this syntax: containerd/containerd@901bcb2 This patch removes the deprecated syntax, the ParseAnyReferenceWithSet function, and the ShortIdentifierRegexp regex. As there are no external consumers for this function, nor the regexp, I'm skipping a deprecation cycle for this; - https://grep.app/search?q=.ShortIdentifierRegexp - https://grep.app/search?q=.ParseAnyReferenceWithSet%28 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Codecov ReportBase: 57.06% // Head: 56.54% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #3774 +/- ##
==========================================
- Coverage 57.06% 56.54% -0.52%
==========================================
Files 105 104 -1
Lines 10806 10642 -164
==========================================
- Hits 6166 6018 -148
+ Misses 3952 3943 -9
+ Partials 688 681 -7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
8cf5d11 to
6d4f62d
Compare
This was referenced Nov 6, 2022
|
Also opened cncf/cncf-fuzzing#235 to remove fuzzing for these |
milosgajdos
approved these changes
Nov 6, 2022
deleteriousEffect
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "shortid" syntax was added in moby/moby@d26a3b3 (moby/moby#799), and allowed for matching an image on its ID prefix (this is before images were content-addressable). With the introduction of content-addressable references, this syntax became problematic, and Docker deprecated this syntax in 2016 (Docker v1.13.0) through commit; moby/moby@5fc7159 (moby/moby#27207):
Support for this syntax was removed in 2017 (Docker 17.12) through commit: moby/moby@a942c92 (moby/moby#35790)
containerd uses a fork of the reference package with this syntax removed, and does not support this syntax:
containerd/containerd@901bcb2 (containerd/containerd#3728)
This patch removes the deprecated syntax, the ParseAnyReferenceWithSet function, and the ShortIdentifierRegexp regex.
As there are no external consumers for this function, nor the regexp, I'm skipping a deprecation cycle for this;