ci: cleanup ci workflow #3644
Merged
ci: cleanup ci workflow #3644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ae72e00 to
aa5bf43
Compare
milosgajdos
approved these changes
May 6, 2022
|
CC: @thaJeztah |
thaJeztah
reviewed
Jun 16, 2022
| fi | ||
|
|
||
| verbosity="${DCO_VERBOSITY--v}" | ||
| GIT_CHECK_EXCLUDE="./vendor:./script/validate/template" git-validation "$verbosity" -range "$COMMIT_RANGE" -run DCO,short-subject,dangling-whitespace |
There was a problem hiding this comment.
The old script was also validating for dangling whitespaces in the commit messages, and for a maximum subject length; do we have a replacement for that?
There was a problem hiding this comment.
Added it back the sandboxed way so we are aligned with the rest of our validation process. See the respective commit.
There was a problem hiding this comment.
Wondering now; if we keep the script, should we keep the DCO in the dockerfile check as well (to allow a local validate)?
Not a blocker for me, but wondering if it's worth keeping, as it's only a extra check in that stage now
There was a problem hiding this comment.
Don't think we need a local validation for DCO imo.
b9012da to
f5f3c98
Compare
Merged
thaJeztah
reviewed
Jul 20, 2022
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up #3634 #3640
remove dco check that is already done by probot and move test step from ci workflow to build workflow and makes build job depends on it so we make sure tests passed before building distribution. tests are not sandboxed yet in our Dockerfile but could do that in a follow-up.