lint target and workflow job #3640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3640 +/- ##
=======================================
Coverage 56.58% 56.58%
=======================================
Files 103 103
Lines 7520 7520
=======================================
Hits 4255 4255
Misses 2596 2596
Partials 669 669 Continue to review full report at Codecov.
|
milosgajdos
approved these changes
May 3, 2022
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
thaJeztah
reviewed
May 4, 2022
| @@ -48,10 +48,6 @@ version/version.go: | |||
| @echo "$(WHALE) $@" | |||
| ./version/version.sh > $@ | |||
|
|
|||
| check: ## run all linters (TODO: enable "unused", "varcheck", "ineffassign", "unconvert", "staticheck", "goimports", "structcheck") | |||
There was a problem hiding this comment.
do we need to keep check as an alias? Or are we ok with removing it? (not sure if there's people expecting make check to be there)
There was a problem hiding this comment.
I dont think it's ever been used out of the GHA workflow context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up #3634
adds lint target with its workflow job and cleanup old check behavior.