Fix s3 driver for supporting ceph radosgw #2879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Radosgw does not support S3 `GET Bucket` API v2 API but v1. This API has backward compatibility, so most of this API is working correctly but we can not get `KeyCount` in v1 API and which is only for v2 API. Signed-off-by: Eohyung Lee <liquidnuker@gmail.com>
sargun
requested changes
Mar 15, 2019
|
Please sign your commits following these rules: $ git clone -b "fix-s3-ceph" git@github.com:tbe/distribution.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842357811480
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
Signed-off-by: Thomas Berger <loki@lokis-chaos.de>
|
ping @dmcgowan @manishtomar @caervs PTAL |
|
@manishtomar ping |
|
Another friendly ping on this ;-) It's still causing crashes on Digitalocean spaces (see #2553 etc) |
|
I'm having the same problem. How do we go from here? Is there going to be a 2.7.2 release soon of the docker registry? |
|
I updated my image to gleez/registry:2.7 with the temporary fix and I have been monitoring the container logs, seems to be working okay |
wy65701436
added a commit
to wy65701436/harbor
that referenced
this pull request
Sep 24, 2019
This commit is target to fix harbor issue goharbor#9186, which root cause is mentioned by distribution/distribution#2553, and fixed by distribution/distribution#2879, As the latest release(v2.7.1) does not contain this fix, but it will break the quota migraion process on S2 driver, we have to path this fix into Harbor regsitry binary. It was already tested by community user. Signed-off-by: wang yan <wangyan@vmware.com>
wy65701436
added a commit
to wy65701436/harbor
that referenced
this pull request
Sep 24, 2019
This commit is target to fix harbor issue goharbor#9186, which root cause is mentioned by distribution/distribution#2553, and fixed by distribution/distribution#2879, As the latest release(v2.7.1) does not contain this fix, but it will break the quota migraion process on S2 driver, we have to path this fix into Harbor regsitry binary. It was already tested by community user. Signed-off-by: wang yan <wangyan@vmware.com>
wy65701436
added a commit
to wy65701436/harbor
that referenced
this pull request
Sep 24, 2019
This commit is target to fix harbor issue goharbor#9186, which root cause is mentioned by distribution/distribution#2553, and fixed by distribution/distribution#2879. As the latest distribution release(v2.7.1) does not contain this fix, but it will break the quota migraion process on S3 storage,we have to path this fix into Harbor regsitry binary. It was already tested by community user. Signed-off-by: wang yan <wangyan@vmware.com>
wy65701436
added a commit
to wy65701436/harbor
that referenced
this pull request
Sep 26, 2019
This commit is target to fix harbor issue goharbor#9186, which root cause is mentioned by distribution/distribution#2553, and fixed by distribution/distribution#2879. As the latest distribution release(v2.7.1) does not contain this fix, but it will break the quota migraion process on S3 storage, we have to path this fix into Harbor regsitry binary. For tag version: it uses the issue number(goharbor#2552) as the tag naming convention. [Note] So far, this fix is only targets on docker regsitry v2.7.1. If the registry has this fix in new release, we'll move on. Signed-off-by: wang yan <wangyan@vmware.com>
wy65701436
added a commit
to wy65701436/harbor
that referenced
this pull request
Sep 26, 2019
This commit is target to fix harbor issue goharbor#9186, which root cause is mentioned by distribution/distribution#2553, and fixed by distribution/distribution#2879. As the latest distribution release(v2.7.1) does not contain this fix, but it will break the quota migraion process on S3 storage, we have to path this fix into Harbor regsitry binary. [Tag Version] It uses the issue number(2553) as the tag naming convention, like v2.7.1-patch-2553, means that we patch the fix of issue 2553 into v2.7.1. [Note] So far, this fix is only targets on docker regsitry v2.7.1. If the registry has this fix in new release, we'll move on. Signed-off-by: wang yan <wangyan@vmware.com>
wy65701436
added a commit
to wy65701436/harbor
that referenced
this pull request
Sep 26, 2019
This commit is target to fix harbor issue goharbor#9186, which root cause is mentioned by distribution/distribution#2553, and fixed by distribution/distribution#2879. As the latest distribution release(v2.7.1) does not contain this fix, but it will break the quota migraion process on S3 storage, we have to path this fix into Harbor regsitry binary. [Tag Version] It uses the issue number(2553) as the tag naming convention, like v2.7.1-patch-2553, means that we patch the fix of issue 2553 into v2.7.1. [Note] So far, this fix is only targets on docker regsitry v2.7.1. If the registry has this fix in new release, we'll move on. Signed-off-by: wang yan <wangyan@vmware.com>
wy65701436
added a commit
to wy65701436/harbor
that referenced
this pull request
Jul 22, 2020
To update the distribution to release/2.7 latest code, it contains the code to resolve distribution/distribution#2553 by distribution/distribution#2879. The regsitryctl needs this PR, otherwise when to call delete manifest API, it will raise unknown issue on S3. Jul 22 09:38:41 172.23.0.1 registryctl[4547]: 2020-07-22T09:38:41Z [ERROR] [/lib/http/error.go:54]: {"errors":[{"code":"UNKNOWN","message":"unknown: s3aws: Path not found: /docker/registry/v2/repositories/library/redis/_manifests/revisions/sha256/7d1ebef417593273b2f7b137f615393b21723d93568868c7fe5aad0401469152"}]} Signed-off-by: wang yan <wangyan@vmware.com>
dylanrhysscott
pushed a commit
to digitalocean/docker-distribution
that referenced
this pull request
Jan 5, 2023
* replaced docker/docker with moby/moby * fixed incorrect name changes in release notes * fixed mentions of moby/moby in code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Radosgw does not support S3
GET BucketAPI v2 API but v1.This API has backward compatibility, so most of this API is working
correctly but we can not get
KeyCountin v1 API and which is onlyfor v2 API.
Signed-off-by: Eohyung Lee liquidnuker@gmail.com
Fixes: #2553