Skip to content

Conversation

Vad1mo
Copy link
Contributor

@Vad1mo Vad1mo commented Mar 20, 2025

Resolves #4494 replaces, closes #4567, including recommendations from @thaJeztah

resolves distribution#4494 replaces distribution#4567

Signed-off-by: Vadim Bauer <vb@container-registry.com>
@Vad1mo Vad1mo changed the title fix: leak Fix potential resource leak by ensuring the response body is closed in HTTPReadSeeker Mar 20, 2025
@Vad1mo
Copy link
Contributor Author

Vad1mo commented Mar 20, 2025

@milosgajdos, read to go..

@milosgajdos milosgajdos requested a review from thaJeztah March 20, 2025 17:44
@milosgajdos
Copy link
Member

PTAL @thaJeztah

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but take that with a grain of salt as I partially wrote this code 🥹❤️

@milosgajdos milosgajdos merged commit c6d55cb into distribution:main Mar 20, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible handle leak in http_reader.go
3 participants