Skip to content

Conversation

thaJeztah
Copy link
Member

This fixes compatibility with alpine 3.21 and file 5.46+

  • Fix additional possible xx-cc/xx-cargo compatibility issue with Alpine 3.21
  • Support for Alpine 3.21
  • Fix xx-verify with file 5.46+
  • Fix possible error taking lock in xx-apk in latest Alpine without coreutils

full diff: tonistiigi/xx@v1.2.1...v1.6.1

This fixes compatibility with alpine 3.21 and file 5.46+

- Fix additional possible `xx-cc`/`xx-cargo` compatibility issue with Alpine 3.21
- Support for Alpine 3.21
- Fix `xx-verify` with `file` 5.46+
- Fix possible error taking lock in `xx-apk` in latest Alpine without `coreutils`

full diff: tonistiigi/xx@v1.2.1...v1.6.1

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah added status/2-code-review dependencies Pull requests that update a dependency file labels Dec 10, 2024
@thaJeztah thaJeztah self-assigned this Dec 10, 2024
Copy link
Member

@milosgajdos milosgajdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@thaJeztah
Copy link
Member Author

I wasn't sure if we'd hit that issue here, but I thought let me update before we do, as one of the errors was rather "surprising" tonistiigi/xx#174 (comment)

@milosgajdos
Copy link
Member

I'm wondering @thaJeztah, since our images use alpine 1.20

ARG ALPINE_VERSION=3.20

We might wanna bump alpine versions, too 🤔

@thaJeztah
Copy link
Member Author

Yeah, I saw the Go version could also use an update; decided to keep this PR to just the xx bump, but can open a follow

@thaJeztah
Copy link
Member Author

That said, it's probably fine to stick to 3.20 for now though, in case there's other subtle changes hiding; 3.20 is still supported (3.21 was only just released).

@milosgajdos
Copy link
Member

milosgajdos commented Dec 10, 2024

That said, it's probably fine to stick to 3.20 for now though, in case there's other subtle changes hiding; 3.20 is still supported (3.21 was only just released).

Yeah, I saw the release is still super hot right out of the oven, but it's worth mentioning we've had a few people telling us their image scanners are triggering alerts (distribution/distribution-library-image#171) because 3.20 has a TLS vulnerability btw (https://hub.docker.com/layers/library/alpine/3.20/images/sha256-029a752048e32e843bd6defe3841186fb8d19a28dae8ec287f433bb9d6d1ad85?context=explore)

Hence my suggestion is to bump it if we can

milosgajdos added a commit to milosgajdos/distribution that referenced this pull request Dec 12, 2024
3.20 had a minor security vulnerability. Let's bump it.

Related:
* distribution/distribution-library-image#171
* distribution#4527

Signed-off-by: Milos Gajdos <milosthegajdos@gmail.com>
@milosgajdos milosgajdos merged commit b2ae9e3 into distribution:main Dec 12, 2024
17 checks passed
@thaJeztah thaJeztah deleted the bump_xx branch December 12, 2024 10:56
@thaJeztah
Copy link
Member Author

Yeah, I saw the release is still super hot right out of the oven, but it's worth mentioning we've had a few people telling us their image scanners are triggering alerts (distribution/distribution-library-image#171) because 3.20 has a TLS vulnerability btw (https://hub.docker.com/layers/library/alpine/3.20/images/sha256-029a752048e32e843bd6defe3841186fb8d19a28dae8ec287f433bb9d6d1ad85?context=explore)

Oh! Looks like I missed your comment

Looks like upstream OpenSSL considered it low enough to not even issue a security release for it; might still be OK to update, OTOH, 3.20 is still supported, so it's worth wondering if updating this early in 3.21 brings more risks than the CVE mentioned is addressing;

https://openssl-library.org/news/secadv/20241016.txt

Due to the low severity of this issue we are not issuing new releases of
OpenSSL at this time. The fix will be included in the next release of each
branch, once it becomes available. The fix is also available in commit
c0d3e4d3 (for 3.3), commit bc7e04d7 (for 3.2), commit fdf67233 (for 3.1)
and commit 72ae83ad (for 3.0) in the OpenSSL git repository. It is available
to premium support customers in commit 8efc0cba (for 1.1.1) and in commit
9d576994 (for 1.0.2).

milosgajdos added a commit to milosgajdos/distribution that referenced this pull request Dec 12, 2024
3.20 had a minor security vulnerability. Let's bump it.

Related:
* distribution/distribution-library-image#171
* distribution#4527

Signed-off-by: Milos Gajdos <milosthegajdos@gmail.com>
milosgajdos added a commit to milosgajdos/distribution that referenced this pull request Dec 12, 2024
3.20 had a minor security vulnerability. Let's bump it.

Related:
* distribution/distribution-library-image#171
* distribution#4527

Bump Go version
* CI
* go.mod

Signed-off-by: Milos Gajdos <milosthegajdos@gmail.com>
@milosgajdos
Copy link
Member

I think it's fine - we're not bumping the official release; we would be bumping the edge release with it, so I see no harm in it. We will bump the official and DOI release later when it's matured a bit more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build dependencies Pull requests that update a dependency file status/2-code-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants