-
Notifications
You must be signed in to change notification settings - Fork 2.6k
update xx to v1.6.1 for compatibility with alpine 3.21 and file 5.46+ #4527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This fixes compatibility with alpine 3.21 and file 5.46+ - Fix additional possible `xx-cc`/`xx-cargo` compatibility issue with Alpine 3.21 - Support for Alpine 3.21 - Fix `xx-verify` with `file` 5.46+ - Fix possible error taking lock in `xx-apk` in latest Alpine without `coreutils` full diff: tonistiigi/xx@v1.2.1...v1.6.1 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I wasn't sure if we'd hit that issue here, but I thought let me update before we do, as one of the errors was rather "surprising" tonistiigi/xx#174 (comment) |
I'm wondering @thaJeztah, since our images use alpine 1.20 Line 4 in f2658ee
We might wanna bump alpine versions, too 🤔 |
Yeah, I saw the Go version could also use an update; decided to keep this PR to just the xx bump, but can open a follow |
That said, it's probably fine to stick to 3.20 for now though, in case there's other subtle changes hiding; 3.20 is still supported (3.21 was only just released). |
Yeah, I saw the release is still super hot right out of the oven, but it's worth mentioning we've had a few people telling us their image scanners are triggering alerts (distribution/distribution-library-image#171) because Hence my suggestion is to bump it if we can |
3.20 had a minor security vulnerability. Let's bump it. Related: * distribution/distribution-library-image#171 * distribution#4527 Signed-off-by: Milos Gajdos <milosthegajdos@gmail.com>
Oh! Looks like I missed your comment Looks like upstream OpenSSL considered it low enough to not even issue a security release for it; might still be OK to update, OTOH, 3.20 is still supported, so it's worth wondering if updating this early in 3.21 brings more risks than the CVE mentioned is addressing; https://openssl-library.org/news/secadv/20241016.txt
|
3.20 had a minor security vulnerability. Let's bump it. Related: * distribution/distribution-library-image#171 * distribution#4527 Signed-off-by: Milos Gajdos <milosthegajdos@gmail.com>
3.20 had a minor security vulnerability. Let's bump it. Related: * distribution/distribution-library-image#171 * distribution#4527 Bump Go version * CI * go.mod Signed-off-by: Milos Gajdos <milosthegajdos@gmail.com>
I think it's fine - we're not bumping the official release; we would be bumping the |
This fixes compatibility with alpine 3.21 and file 5.46+
xx-cc
/xx-cargo
compatibility issue with Alpine 3.21xx-verify
withfile
5.46+xx-apk
in latest Alpine withoutcoreutils
full diff: tonistiigi/xx@v1.2.1...v1.6.1