-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Build artifacts and images for linux/riscv64 #4444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build artifacts and images for linux/riscv64 #4444
Conversation
Signed-off-by: Matheus Macabu <macabu.matheus@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has RISC-V support in Go been marked as stable? I don't develop for that platform so I'm curious.
To be honest I don't know if the Go team has such a thing as different support "tiers". RISC-V target is recent (from Go 1.21.0), but in my experience building a bunch of different projects, I haven't had any weird compiler error, crash, or misbehaving as far as my tests went. |
It's not so much about "support tiers" as it is about Go runtime support. It seems though that it's more or less "covered" https://groups.google.com/g/golang-nuts/c/m4OF6nieGro |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine so LGTM, but let's see what other maintainers say :)
PTAL @thaJeztah
Thanks for linking it, I wasn't aware 🙇 |
FWIW; if the intent is to also have riscv variants in the official image, then changes are probably also needed in https://github.com/distribution/distribution-library-image and https://github.com/docker-library/official-images/blob/fb18daaa4388ddc39121d22701d9c0e266c61e27/library/registry |
Of course. It'll be done. At some point. |
Let me know and I can test it! Would this make the cut for 3.0 or later? |
The only notable change is the addition of riscv plaform. See: distribution/distribution#4444 Signed-off-by: Milos Gajdos <milosthegajdos@gmail.com>
As part of the effort to be able to build
moby/moby
in Docker-in-Docker fashion forlinux/riscv64
natively, it requires this image to be build so as well.Dependency from https://github.com/moby/moby/blob/master/Dockerfile#L95
I've been able to build and do a basic run of the binary in my riscv64 host: