Skip to content

fix nil pointer in s3 list api #4412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2024
Merged

fix nil pointer in s3 list api #4412

merged 1 commit into from
Jul 19, 2024
+12 −12

Conversation

jkroepke
Copy link
Contributor

@jkroepke jkroepke commented Jul 19, 2024 •
edited
Loading

Fixes #4411
Ref: project-zot/zot#2532

On other situations, a nil check is present.

distribution/registry/storage/driver/s3-aws/s3.go

Line 760 in 2526198

if resp.IsTruncated == nil || !*resp.IsTruncated {

There are still some missing nil checks, not sure

distribution/registry/storage/driver/s3-aws/s3.go

Line 740 in 2526198

for *partsList.IsTruncated {

distribution/registry/storage/driver/s3-aws/s3.go

Line 727 in 2526198

if key != *multi.Key {

distribution/registry/storage/driver/s3-aws/s3.go

Line 794 in 2526198

if *resp.Contents[0].Key != s3Path {

distribution/registry/storage/driver/s3-aws/s3.go

Lines 778 to 779 in 2526198

Size: *resp.ContentLength,
ModTime: *resp.LastModified,

distribution/registry/storage/driver/s3-aws/s3.go

Line 682 in 2526198

return d.newWriter(ctx, key, *resp.UploadId, nil), nil

@jkroepke
fix nil pointer in s3 list api
8619a11 
Signed-off-by: Jan-Otto Kröpke <github@jkroepke.de>
@jkroepke jkroepke mentioned this pull request Jul 19, 2024
Closed
@milosgajdos milosgajdos merged commit 2577121 into distribution:main Jul 19, 2024
16 checks passed
@milosgajdos milosgajdos mentioned this pull request Jul 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corhere corhere corhere approved these changes

@milosgajdos milosgajdos milosgajdos approved these changes

@thaJeztah thaJeztah Awaiting requested review from thaJeztah

@Jamstah Jamstah Awaiting requested review from Jamstah

Assignees
No one assigned
Labels
area/storage/s3 area/storage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

S3 driver: panic: runtime error: invalid memory address or nil pointer dereference
3 participants
@jkroepke @corhere @milosgajdos