feat: implement 'rewrite' storage middleware #4146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milosgajdos
reviewed
Oct 31, 2023
58547e7 to
24ad324
Compare
milosgajdos
approved these changes
Nov 23, 2023
There was a problem hiding this comment.
This seems reasonable to me.
PTAL @thaJeztah @Jamstah @davidspek
|
ping @thaJeztah @Jamstah |
|
@corhere mind having a look at this? Thanks 🙇 |
|
Ping @thaJeztah @squizzi |
|
@smira mind adding some basics docs in, please? |
24ad324 to
97f8d92
Compare
done, rebased, adapted to the changes |
milosgajdos
reviewed
Jul 4, 2024
There was a problem hiding this comment.
Thanks @smira, mind fixing the YAML indentation I mentioned in my comments, please?
This allows to rewrite 'URLFor' of the storage driver to use a specific host/trim the base path. It is different from the 'redirect' middleware, as it still calls the storage driver URLFor. For example, with Azure storage provider, this allows to transform the SAS Azure Blob Storage URL into the URL compatible with Azure Front Door. Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
97f8d92 to
558ace1
Compare
milosgajdos
added a commit
to milosgajdos/distribution
that referenced
this pull request
Aug 15, 2024
distribution#4146 introduced a new rewrite storage middleware but somehow missed to update the init logging message. This commit fixes that. Signed-off-by: Milos Gajdos <milosthegajdos@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to rewrite 'URLFor' of the storage driver to use a specific host/trim the base path.
It is different from the 'redirect' middleware, as it still calls the storage driver URLFor.
For example, with Azure storage provider, this allows to transform the SAS Azure Blob Storage URL into the URL compatible with Azure Front Door.