Skip to content

[release/2.8 backport] Enable Go build tags #4009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 22, 2023
Merged

[release/2.8 backport] Enable Go build tags #4009

merged 3 commits into from
Aug 22, 2023

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Aug 21, 2023 •
edited
Loading

milosgajdos and others added 3 commits August 21, 2023 13:50
@milosgajdos @thaJeztah
Enable Go build tags
2548973 
This enables go build tags so the GCS and OSS driver support is
available in the binary distributed via the image build by Dockerfile.

This led to quite a few fixes in the GCS and OSS packages raised as
warning by golang-ci linter.

Signed-off-by: Milos Gajdos <milosthegajdos@gmail.com>
(cherry picked from commit 6b388b1)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
s3: add interface assertion
2d62a40 
This was added for the other drivers in 6b388b1,
but it missed the s3 storage driver.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 5b3be39)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@milosgajdos @thaJeztah
Enable build tags in 2.8
110cb75 
It would appear we were missing the Go build tags on 2.8.X branch so the
images would not have the necessary support for some storage drivers
causing breakages to end users trying to use them.

This commit fixes both the build and linting issues.

Signed-off-by: Milos Gajdos <milosthegajdos@gmail.com>
@thaJeztah thaJeztah mentioned this pull request Aug 21, 2023
Closed
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (7c354a4) 58.87% compared to head (110cb75) 58.87%.
Report is 2 commits behind head on release/2.8.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@             Coverage Diff              @@
##           release/2.8    #4009   +/-   ##
============================================
  Coverage        58.87%   58.87%           
============================================
  Files              102      102           
  Lines             7120     7120           
============================================
  Hits              4192     4192           
  Misses            2284     2284           
  Partials           644      644

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@milosgajdos
Copy link
Member

Do you wanna close this one @thaJeztah as it's a dupe of #3927 which was open earlier.

@milosgajdos
Copy link
Member

@thaJeztah can you mark this ready for review?

@thaJeztah thaJeztah marked this pull request as ready for review August 22, 2023 14:03
davidspek
davidspek approved these changes Aug 22, 2023
View reviewed changes
Copy link
Collaborator

@davidspek davidspek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@milosgajdos milosgajdos merged commit 27206bc into distribution:release/2.8 Aug 22, 2023
@thaJeztah thaJeztah deleted the 2.8_backport_enable_build_tags branch August 22, 2023 14:56
@milosgajdos milosgajdos mentioned this pull request Aug 31, 2023
Merged
@milosgajdos milosgajdos mentioned this pull request Sep 13, 2023
Closed
nrdufour added a commit to nrdufour/home-ops that referenced this pull request Oct 3, 2023
@nrdufour
chore(deps): update registry docker tag to v2.8.3 (#127)
7efb94f 
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [registry](https://github.com/distribution/distribution) | patch | `2.8.2` -> `2.8.3` |

---

### ⚠ Dependency Lookup Warnings ⚠

Warnings were logged while processing this repo. Please check the logs for more information.

---

### Release Notes

<details>
<summary>distribution/distribution (registry)</summary>

### [`v2.8.3`](https://github.com/distribution/distribution/releases/tag/v2.8.3)

[Compare Source](distribution/distribution@v2.8.2...v2.8.3)

##### What's Changed

-   Pass `BUILDTAGS` argument to `go build` by [@&#8203;marcusirgens](https://github.com/marcusirgens) in distribution/distribution#3926
-   Enable Go build tags by [@&#8203;thaJeztah](https://github.com/thaJeztah) in distribution/distribution#4009
-   `reference`: replace deprecated function `SplitHostname` by [@&#8203;thaJeztah](https://github.com/thaJeztah) in distribution/distribution#4032
-   Dont parse errors as JSON unless Content-Type is set to JSON by [@&#8203;thaJeztah](https://github.com/thaJeztah) in distribution/distribution#4054
-   update to go 1.20.8 by [@&#8203;thaJeztah](https://github.com/thaJeztah) in distribution/distribution#4056
-   Set `Content-Type` header in registry client `ReadFrom` by [@&#8203;thaJeztah](https://github.com/thaJeztah) in distribution/distribution#4053
-   deprecate reference package, migrate to github.com/distribution/reference by [@&#8203;thaJeztah](https://github.com/thaJeztah) in distribution/distribution#4063
-   `digestset`: deprecate package in favor of `go-digest/digestset`  by [@&#8203;thaJeztah](https://github.com/thaJeztah) in distribution/distribution#4064
-   Do not close HTTP request body in HTTP handler by [@&#8203;milosgajdos](https://github.com/milosgajdos) in distribution/distribution#4068
-   Add v2.8.3 release notes by [@&#8203;milosgajdos](https://github.com/milosgajdos) in distribution/distribution#4088

##### New Contributors

-   [@&#8203;marcusirgens](https://github.com/marcusirgens) made their first contribution in distribution/distribution#3926

**Full Changelog**: distribution/distribution@v2.8.2...v2.8.3

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zLjIiLCJ1cGRhdGVkSW5WZXIiOiIzNy4zLjIiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=-->

Reviewed-on: https://git.home/nrdufour/home-ops/pulls/127
Co-authored-by: Renovate <renovate@ptinem.io>
Co-committed-by: Renovate <renovate@ptinem.io>
Mengkzhaoyun pushed a commit to open-beagle/distribution that referenced this pull request Dec 14, 2023
Merge tag 'v2.8.3'
3a680cb 
registry 2.8.3

Welcome to the v2.8.3 release of registry!

Welcome to the 2.8.3 release of registry!

The 2.8.3 registry release fixes a few bugs and makes a few dependency updates.
The Go runtime has been bumped to 1.20.8.

See the changelog below for full list of changes.

* Do not close HTTP request body in HTTP handler ([distribution#4068](distribution#4068))
* Set Content-Type header in registry client ReadFrom ([distribution#4053](distribution#4053))
* Do not parse errors as JSON unless Content-Type is set to JSON ([distribution#4054](distribution#4054))
* Enable Go build tags ([distribution#4009](distribution#4009))

* replace deprecated function SplitHostname ([distribution#4032](distribution#4032))

* update to go1.20.8 ([distribution#4056](distribution#4056))

* deprecate digestset package in favor of go-digest/digestset  ([distribution#4064](distribution#4064))
* deprecate reference package, migrate to github.com/distribution/reference ([distribution#4063](distribution#4063))

Previous release can be found at [v2.8.2](https://github.com/distribution/distribution/releases/tag/v2.8.2)

Please try out the release binaries and report any issues at
https://github.com/distribution/distribution/issues.

* Milos Gajdos
* Sebastiaan van Stijn
* Milos Gajdos
* James Hewitt
* Ben Manuel
* Marcus Pettersen Irgens
* zounengren
<details><summary>30 commits</summary>
<p>

* Add v2.8.3 release notes ([distribution#4088](distribution#4088))
  * [`a4fa6992`](distribution@a4fa699) Add v2.8.3 release notes
* [release/2.8] Do not close HTTP request body in HTTP handler ([distribution#4068](distribution#4068))
  * [`5e6b1b5c`](distribution@5e6b1b5) Do not close HTTP request body in HTTP handler
* [release/2.8] digestset: deprecate package in favor of go-digest/digestset  ([distribution#4064](distribution#4064))
  * [`29b00e8b`](distribution@29b00e8) digestset: deprecate package in favor of go-digest/digestset
  * [`d1ab2430`](distribution@d1ab243) [release/2.8] vendor: github.com/opencontainers/go-digest v1.0.0
* [release/2.8] deprecate reference package, migrate to github.com/distribution/reference ([distribution#4063](distribution#4063))
  * [`3dda0677`](distribution@3dda067) deprecate reference package, migrate to github.com/distribution/reference
* [release/2.8 backport] Set Content-Type header in registry client ReadFrom ([distribution#4053](distribution#4053))
  * [`cb121c3f`](distribution@cb121c3) Set Content-Type header in registry client ReadFrom
* [release/2.8] update to go1.20.8 ([distribution#4056](distribution#4056))
  * [`3c6f7788`](distribution@3c6f778) update to go1.20.8
  * [`31f5cd48`](distribution@31f5cd4) Handle rand deprecations in go 1.20
  * [`29b8ba0b`](distribution@29b8ba0) Update to go 1.20
  * [`3316b198`](distribution@3316b19) Update to golang 1.19.10
  * [`444d053e`](distribution@444d053) update golangci-lint to v1.52
  * [`b800af44`](distribution@b800af4) ignore SA1019: ac.(*accessController).rootCerts.Subjects has been deprecated
  * [`0a98a00d`](distribution@0a98a00) Ignore SA1019: SplitHostname is deprecated.
* [release/2.8 backport] Dont parse errors as JSON unless Content-Type is set to JSON ([distribution#4054](distribution#4054))
  * [`2ec0471b`](distribution@2ec0471) Dont parse errors as JSON unless Content-Type is set to JSON
* [release/2.8 backport] reference: replace deprecated function SplitHostname ([distribution#4032](distribution#4032))
  * [`b57133cc`](distribution@b57133c) referene: fix formatting of "deprecated" comment.
  * [`2c4bf1a6`](distribution@2c4bf1a) replace deprecated function
* [release/2.8 backport] Enable Go build tags ([distribution#4009](distribution#4009))
  * [`110cb753`](distribution@110cb75) Enable build tags in 2.8
  * [`2d62a402`](distribution@2d62a40) s3: add interface assertion
  * [`2548973b`](distribution@2548973) Enable Go build tags
* Pass `BUILDTAGS` argument to `go build` ([distribution#3926](distribution#3926))
  * [`ab7178cc`](distribution@ab7178c) Pass BUILDTAGS argument to go build
</p>
</details>

* **github.com/distribution/reference**    49c28499d219 **_new_**
* **github.com/opencontainers/go-digest**  a6d0ee40d420 -> ea51bea511f7

Previous release can be found at [v2.8.2](https://github.com/distribution/distribution/releases/tag/v2.8.2)
quotengrote pushed a commit to quotengrote/ansible that referenced this pull request Jan 26, 2024
@quotengrote
chore(deps): update registry docker tag to v2.8.3 (#667)
274314c 
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [registry](https://github.com/distribution/distribution) | patch | `2.8.2` -> `2.8.3` |

---

> ⚠ **Warning**
>
> Some dependencies could not be looked up. Check the Dependency Dashboard for more information.

---

### Release Notes

<details>
<summary>distribution/distribution (registry)</summary>

### [`v2.8.3`](https://github.com/distribution/distribution/releases/tag/v2.8.3)

[Compare Source](distribution/distribution@v2.8.2...v2.8.3)

#### What's Changed

-   Pass `BUILDTAGS` argument to `go build` by [@&#8203;marcusirgens](https://github.com/marcusirgens) in distribution/distribution#3926
-   Enable Go build tags by [@&#8203;thaJeztah](https://github.com/thaJeztah) in distribution/distribution#4009
-   `reference`: replace deprecated function `SplitHostname` by [@&#8203;thaJeztah](https://github.com/thaJeztah) in distribution/distribution#4032
-   Dont parse errors as JSON unless Content-Type is set to JSON by [@&#8203;thaJeztah](https://github.com/thaJeztah) in distribution/distribution#4054
-   update to go 1.20.8 by [@&#8203;thaJeztah](https://github.com/thaJeztah) in distribution/distribution#4056
-   Set `Content-Type` header in registry client `ReadFrom` by [@&#8203;thaJeztah](https://github.com/thaJeztah) in distribution/distribution#4053
-   deprecate reference package, migrate to github.com/distribution/reference by [@&#8203;thaJeztah](https://github.com/thaJeztah) in distribution/distribution#4063
-   `digestset`: deprecate package in favor of `go-digest/digestset`  by [@&#8203;thaJeztah](https://github.com/thaJeztah) in distribution/distribution#4064
-   Do not close HTTP request body in HTTP handler by [@&#8203;milosgajdos](https://github.com/milosgajdos) in distribution/distribution#4068
-   Add v2.8.3 release notes by [@&#8203;milosgajdos](https://github.com/milosgajdos) in distribution/distribution#4088

#### New Contributors

-   [@&#8203;marcusirgens](https://github.com/marcusirgens) made their first contribution in distribution/distribution#3926

**Full Changelog**: distribution/distribution@v2.8.2...v2.8.3

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNTIuMSIsInVwZGF0ZWRJblZlciI6IjM3LjE1Mi4xIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->

Reviewed-on: https://git.mgrote.net/mg/homeserver/pulls/667
Co-authored-by: Renovate Bot <renovate@mgrote.net>
Co-committed-by: Renovate Bot <renovate@mgrote.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milosgajdos milosgajdos milosgajdos approved these changes

@davidspek davidspek davidspek approved these changes

@deleteriousEffect deleteriousEffect Awaiting requested review from deleteriousEffect

@wy65701436 wy65701436 Awaiting requested review from wy65701436

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thaJeztah @codecov-commenter @milosgajdos @davidspek