Skip to content

feat(Shard): add eval context #7011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 23, 2021
Merged

feat(Shard): add eval context #7011

merged 4 commits into from
Nov 23, 2021

Conversation

daimond113
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:

Adds a context parameter to Shard#eval.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@daimond113 daimond113 marked this pull request as draft November 20, 2021 14:28
SpaceEEC
SpaceEEC reviewed Nov 20, 2021
View reviewed changes
daimond113 and others added 2 commits November 20, 2021 15:34
@daimond113 @SpaceEEC
chore: rename type parameter
76a6c44 
Co-authored-by: SpaceEEC <spaceeec@yahoo.com>
@daimond113
chore: fix types
cd9dd34
@daimond113 daimond113 marked this pull request as ready for review November 20, 2021 14:44
@daimond113 daimond113 requested a review from SpaceEEC November 20, 2021 14:48
@iCrawl iCrawl added this to the Version 13.4 milestone Nov 23, 2021
@iCrawl iCrawl merged commit 77aff08 into discordjs:main Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iCrawl iCrawl iCrawl approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

Assignees
No one assigned
Labels
semver:minor sharding utility
Projects
discord.js
Archived in project
Milestone
Version 13.4
Development

Successfully merging this pull request may close these issues.
3 participants
@daimond113 @iCrawl @SpaceEEC