Create SafeDIPrebuiltGenerator + enable using prebuilt SwiftSyntax binary in Swift 6.1.1 #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #161 +/- ##
=======================================
Coverage 99.91% 99.91%
=======================================
Files 32 32
Lines 3461 3461
=======================================
Hits 3458 3458
Misses 3 3
🚀 New features to boost your workflow:
|
dfed
added a commit
that referenced
this pull request
Aug 18, 2025
Undoes some of hacked support for prebuilt SwiftSyntax binaries in Xcode 16.4 using Swift 6.1.1 added in #161. Required for compiling with Swift 6.2, but does **not** compile when building with Swift 6.1.1 and `defaults write com.apple.dt.Xcode IDEPackageEnablePrebuilts YES`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prebuilt SwiftSyntax is here, but it's only for macros, which means that in order to take advantage of prebuilt SwiftSyntax, we need to vend a Plugin that does not depend on SwiftSyntax.
This PR creates
SafeDIPrebuiltGenerator, which enables adoptees to depend onSafeDIand generate a DI tree without needing to compileSwiftSyntax.In order to unblock building SafeDI with the
IDEPackageEnablePrebuiltsuser default enabled in Xcode 16.4, I have made it such thatSafeDICoreis no longer a module that is shared between both the plugin and macro target by symlinkingSafeDICore's code intoSafeDIMacros. Ideally we'll be able to undo this hack in a future Xcode release.