Skip to content

new icon: zustand (original) #2358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 16, 2025
Merged

new icon: zustand (original) #2358

merged 7 commits into from
Mar 16, 2025

Conversation

pikooli
Copy link
Contributor

@pikooli pikooli commented Feb 14, 2025

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file at the correct alphabetic position as seen here

This PR closes NONE
#2292

Link to prove your SVG is correct and up-to-date.

I take the svg from here and adapt the viewport :
pmndrs/zustand#1623

@pikooli
Copy link
Contributor Author

pikooli commented Feb 14, 2025

@ConX @Snailedlt @canaleal is this PR not good ?

@canaleal canaleal added the feature:icon PR when a new icon is ready to be added to the collection label Feb 16, 2025
canaleal
canaleal requested changes Feb 17, 2025
View reviewed changes
@pikooli pikooli force-pushed the zustand branch 2 times, most recently from 79ea42d to c8897a2 Compare February 28, 2025 14:44
@pikooli pikooli requested a review from canaleal March 1, 2025 11:59
@pikooli pikooli force-pushed the zustand branch 3 times, most recently from dd1c9d8 to 9853b05 Compare March 6, 2025 15:03
@pikooli
Copy link
Contributor Author

pikooli commented Mar 13, 2025

@canaleal if you have some time to re review this PR
Thanks a lots

@canaleal
Copy link
Member

@pikooli sorry I was incredibly busy with work. Taking a look now.

@pikooli
Copy link
Contributor Author

pikooli commented Mar 15, 2025

@pikooli sorry I was incredibly busy with work. Taking a look now.

no worry mate, thanks a lots

canaleal
canaleal previously approved these changes Mar 16, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@canaleal canaleal merged commit 1751189 into devicons:develop Mar 16, 2025
5 checks passed
@canaleal canaleal mentioned this pull request Jun 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canaleal canaleal canaleal approved these changes

Assignees
No one assigned
Labels
feature:icon PR when a new icon is ready to be added to the collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pikooli @canaleal